f: reverse SubgraphServiceIndexingAgreementAlreadyAllocated

Author: matiasedgeandnode

IndexingPaymentsTodo.md

@@ -4,7 +4,6 @@
 * Update Arbitration Charter to support disputing Indexing Fees. DONE: ~~Support `DisputeManager`~~
 * Make `agreementId` unique globally so that we don't need the full tuple (`payer`+`indexer`+`agreementId`) as key?
 * Rename `Decoder.sol` - Maybe turn it into a library instead?
-* Reverse name of `SubgraphServiceIndexingAgreementAlreadyAllocated`?
 * Support indexing agreement upgadeability, so that there is a mechanism to adjust the rates without having to cancel and start over.
 * Support for agreements that end up in `RecurringCollectorCollectionTooLate` or ways to avoid getting to that state.
 * Should we deal with zero entities declared as a special case?

packages/subgraph-service/contracts/SubgraphService.sol

@@ -761,7 +761,7 @@ contract SubgraphService is
 
         require(
             _isZeroIndexingAgreementKey(allocationToActiveAgreementKey[_allocationId]),
-            SubgraphServiceIndexingAgreementAlreadyAllocated(_allocationId)
+            SubgraphServiceAllocationAlreadyHasIndexingAgreement(_allocationId)
         );
         allocationToActiveAgreementKey[_allocationId] = key;
 

packages/subgraph-service/contracts/interfaces/ISubgraphService.sol

@@ -402,7 +402,7 @@ interface ISubgraphService is IDataServiceFees {
      * @notice Thrown when an allocation already has an active agreement
      * @param allocationId The allocation ID
      */
-    error SubgraphServiceIndexingAgreementAlreadyAllocated(address allocationId);
+    error SubgraphServiceAllocationAlreadyHasIndexingAgreement(address allocationId);
 
     /**
      * @notice Thrown when caller can not cancel an agreement