fix: output lcov coverage for CI Codecov upload

Add test:coverage:self scripts that output lcov.info to coverage/
for issuance, horizon, and subgraph-service. Create coverage dir
before running forge coverage (forge does not create it). Update
CI workflow to find both Istanbul JSON and lcov coverage files.

Author: RembrandtK

.github/workflows/build-test.yml

@@ -33,8 +33,8 @@ jobs:
       - name: Find coverage files
         id: coverage_files
         run: |
-          # Find all coverage-final.json files
-          COVERAGE_FILES=$(find ./packages -name "coverage-final.json" -path "*/coverage/*" | tr '\n' ',' | sed 's/,$//')
+          # Find coverage files: Istanbul JSON (Hardhat) and lcov (Forge)
+          COVERAGE_FILES=$(find ./packages \( -name "coverage-final.json" -o -name "lcov.info" \) -path "*/coverage/*" | tr '\n' ',' | sed 's/,$//')
           echo "files=$COVERAGE_FILES" >> $GITHUB_OUTPUT
           echo "Found coverage files: $COVERAGE_FILES"
 

packages/horizon/package.json

@@ -35,7 +35,7 @@
     "test:deployment": "SECURE_ACCOUNTS_DISABLE_PROVIDER=true hardhat test test/deployment/*.ts",
     "test:integration": "./scripts/integration",
     "test:coverage": "pnpm build && pnpm test:coverage:self",
-    "test:coverage:self": "forge coverage",
+    "test:coverage:self": "mkdir -p coverage && forge coverage --report lcov --report-file coverage/lcov.info",
     "prepublishOnly": "pnpm run build"
   },
   "devDependencies": {

packages/issuance/package.json

@@ -29,6 +29,7 @@
     "typechain": "typechain --target ethers-v6 --out-dir typechain-src 'artifacts/contracts/**/!(*.dbg).json' && tsc -p tsconfig.typechain.json && rm -rf typechain-src && echo '{\"type\":\"commonjs\"}' > types/package.json",
     "test": "forge test",
     "test:coverage": "forge coverage",
+    "test:coverage:self": "mkdir -p coverage && forge coverage --report lcov --report-file coverage/lcov.info",
     "lint": "pnpm lint:ts; pnpm lint:sol; pnpm lint:forge; pnpm lint:md; pnpm lint:json",
     "lint:ts": "eslint '**/*.{js,ts,cjs,mjs,jsx,tsx}' --fix --cache; prettier -w --cache --log-level warn '**/*.{js,ts,cjs,mjs,jsx,tsx}'",
     "lint:sol": "solhint --fix --noPrompt --noPoster 'contracts/**/*.sol'; prettier -w --cache --log-level warn 'contracts/**/*.sol'",

packages/subgraph-service/package.json

@@ -33,7 +33,7 @@
     "test:deployment": "SECURE_ACCOUNTS_DISABLE_PROVIDER=true hardhat test test/deployment/*.ts",
     "test:integration": "./scripts/integration",
     "test:coverage": "pnpm build && pnpm test:coverage:self",
-    "test:coverage:self": "forge coverage",
+    "test:coverage:self": "mkdir -p coverage && forge coverage --report lcov --report-file coverage/lcov.info",
     "prepublishOnly": "pnpm run build"
   },
   "devDependencies": {