docs(reo): correct test-plan facts from full review

Cross-checked every test plan against the contracts and deployed addresses
and fixed the confirmed inaccuracies:

- SubgraphDenial: setDenied is onlySubgraphAvailabilityOracle (Governor
  cannot call it); identify the SAO via RewardsManager.subgraphAvailabilityOracle()
  (not Controller.getContractProxy), with a note that it is typically the
  SubgraphAvailabilityManager voting contract.
- IssuanceAllocatorTestPlan: IssuanceAllocator is deployed on Sepolia
  (0x76a0d756...); fill mainnet RewardsManager/GraphToken addresses; mark
  mainnet IssuanceAllocator "Not yet deployed"; fix getTargetIssuancePerBlock
  signature to the 4-field struct return.
- MainnetDetails: fill in the deployed RewardsEligibilityOracle address.
- ReoTestPlan: clarify renewIndexerEligibility "count" is observable via
  IndexerEligibilityRenewed events, not cast send return values.
- RewardsConditions/SubgraphDenial: point source refs at AllocationHandler.sol
  (where POI/condition handling lives).
- TestnetDetails: drop incorrect chain=arbitrum-one from the Sepolia explorer
  link. README: drop stale "pending deployment". NotionTracker: SAO-only note.

Author: RembrandtK

packages/issuance/docs/testing/reo/IndexerTestGuide.md

@@ -401,7 +401,7 @@ cast call $REO "isEligible(address)(bool)" $INDEXER --rpc-url $RPC
 
 ## Mock REO Test Sets (2m - 4m)
 
-These sets use the `RewardsEligibilityOracleMock` for direct eligibility control. The coordinator must have pointed RewardsManager at the mock. These replace Sets 2-4 when the mock is active.
+These sets use the `RewardsEligibilityOracleMock` for direct eligibility control. On Arbitrum Sepolia the RewardsManager the mock. These replace Sets 2-4 when the mock is active.
 
 ### 2m.1 Close allocation while eligible (mock)
 

packages/issuance/docs/testing/reo/MainnetDetails.md

@@ -25,13 +25,13 @@ curl "https://gateway.thegraph.com/api/$GRAPH_API_KEY/subgraphs/id/DZz4kDTdmzWLW
 
 ## Contract Addresses
 
-| Contract                 | Address                                      |
-| ------------------------ | -------------------------------------------- |
-| RewardsEligibilityOracle | TBD                                          |
-| RewardsManager           | `0x971b9d3d0ae3eca029cab5ea1fb0f72c85e6a525` |
-| SubgraphService          | `0xb2bb92d0de618878e438b55d5846cfecd9301105` |
-| GraphToken (L2)          | `0x9623063377ad1b27544c965ccd7342f7ea7e88c7` |
-| Controller               | `0x0a8491544221dd212964fbb96487467291b2c97e` |
+| Contract                  | Address                                      |
+| ------------------------- | -------------------------------------------- |
+| RewardsEligibilityOracleA | `0x8ec2767a9d9ba02b4e09e8ff4fac2e14a340f304` |
+| RewardsManager            | `0x971b9d3d0ae3eca029cab5ea1fb0f72c85e6a525` |
+| SubgraphService           | `0xb2bb92d0de618878e438b55d5846cfecd9301105` |
+| GraphToken (L2)           | `0x9623063377ad1b27544c965ccd7342f7ea7e88c7` |
+| Controller                | `0x0a8491544221dd212964fbb96487467291b2c97e` |
 
 ---
 

packages/issuance/docs/testing/reo/README.md

@@ -10,7 +10,7 @@ Comprehensive test plans for validating The Graph Network after an upgrade. Thre
 4. **Subgraph denial tests** → [SubgraphDenialTestPlan.md](SubgraphDenialTestPlan.md)
 5. **Reward conditions tests** → [RewardsConditionsTestPlan.md](RewardsConditionsTestPlan.md)
 
-**Mock REO available**: A `RewardsEligibilityOracleMock` at `0x69b0f3c6a19beaf1ba59405f7179e188c64b4e06` (Arbitrum Sepolia) provides instant eligibility control for integration testing. See the mock-based test paths in [ReoTestPlan](ReoTestPlan.md#mock-reo-quick-test-path) and [IndexerTestGuide](IndexerTestGuide.md#mock-reo-option).
+**Mock REO available**: A `RewardsEligibilityOracleMock` at `0x69b0f3c6a19beaf1ba59405f7179e188c64b4e06` (Arbitrum Sepolia) provides instant eligibility control for integration testing. See the mock-based test paths in [ReoTestPlan](ReoTestPlan.md#mock-reo-quick-test-path) and [IndexerTestGuide](IndexerTestGuide.md#mock-reo-default-path).
 
 ## Reading Order
 
@@ -30,13 +30,13 @@ BaselineTestPlan (7 cycles, 22 tests)
   │      Cycle 2.3 opens allocations reused in Cycle 6
   │      Cycle 6m: mock REO path for fast integration testing
   │
-  ├──▶ RewardsConditionsTestPlan (7 cycles, 26 tests)
+  ├──▶ RewardsConditionsTestPlan (7 cycles, 25 tests)
   │      Covers: reclaim config, below-minimum signal, zero allocated tokens,
   │              POI paths (stale/zero/too-young), allocation resize/close, observability
   │      Depends on: Baseline Cycles 1-7 pass first
   │      Cycle 1 configures reclaim addresses used by all reclaim tests
   │
-  ├──▶ SubgraphDenialTestPlan (6 cycles, 18 tests)
+  ├──▶ SubgraphDenialTestPlan (6 cycles, 21 tests)
   │      Covers: deny/undeny state, accumulator freeze, allocation deferral,
   │              pre-denial reward recovery, edge cases
   │      Depends on: Baseline + RewardsConditionsTestPlan Cycle 1 (reclaim setup)
@@ -56,8 +56,8 @@ BaselineTestPlan (7 cycles, 22 tests)
 | ------------------------------------------------------------ | --------------------------------------------------------------------------------------- |
 | [BaselineTestPlan.md](BaselineTestPlan.md)                   | Detailed baseline indexer operational tests (7 cycles, 22 tests)                        |
 | [ReoTestPlan.md](ReoTestPlan.md)                             | REO eligibility, oracle, and rewards integration (8 cycles + mock path, 36 tests)       |
-| [RewardsConditionsTestPlan.md](RewardsConditionsTestPlan.md) | Reclaim system, signal conditions, POI paths, allocation lifecycle (7 cycles, 26 tests) |
-| [SubgraphDenialTestPlan.md](SubgraphDenialTestPlan.md)       | Subgraph denial: accumulator freeze, deferral, recovery (6 cycles, 18 tests)            |
+| [RewardsConditionsTestPlan.md](RewardsConditionsTestPlan.md) | Reclaim system, signal conditions, POI paths, allocation lifecycle (7 cycles, 25 tests) |
+| [SubgraphDenialTestPlan.md](SubgraphDenialTestPlan.md)       | Subgraph denial: accumulator freeze, deferral, recovery (6 cycles, 21 tests)            |
 | [IndexerTestGuide.md](IndexerTestGuide.md)                   | Condensed indexer eligibility tests (5 sets + 3 mock sets, 11 tests)                    |
 
 ## Test Coverage
@@ -139,7 +139,7 @@ BaselineTestPlan (7 cycles, 22 tests)
 5. **Edge Cases**
    - New allocation while denied, all-close-while-denied, rapid deny/undeny, denial vs eligibility precedence
 
-See also: [IssuanceAllocatorTestPlan](support/IssuanceAllocatorTestPlan.md) (independent of REO, pending deployment)
+See also: [IssuanceAllocatorTestPlan](support/IssuanceAllocatorTestPlan.md) (independent of REO)
 
 ## Network Configuration
 

packages/issuance/docs/testing/reo/ReoTestPlan.md

@@ -153,7 +153,7 @@ cast keccak $(cast code <IMPLEMENTATION_ADDRESS> --rpc-url <RPC>)
 
 **Pass Criteria**:
 
-- Implementation address matches address book (`0x4eb1de98440a39339817bdeeb3b3fff410b0b924` on Sepolia)
+- Implementation address matches address book (`0xd6f2acf352f655b72cc32a056edf7ca97ec3e9e4` on Sepolia)
 - Bytecode hash matches expected artifact hash
 
 ---
@@ -166,7 +166,7 @@ cast keccak $(cast code <IMPLEMENTATION_ADDRESS> --rpc-url <RPC>)
 
 ```bash
 # Role constants
-GOVERNOR_ROLE=0x0000...  # DEFAULT_ADMIN_ROLE = 0x00
+GOVERNOR_ROLE=$(cast keccak "GOVERNOR_ROLE")  # self-administered, not OZ DEFAULT_ADMIN (0x00)
 OPERATOR_ROLE=$(cast keccak "OPERATOR_ROLE")
 ORACLE_ROLE=$(cast keccak "ORACLE_ROLE")
 PAUSE_ROLE=$(cast keccak "PAUSE_ROLE")
@@ -223,7 +223,7 @@ cast call <REWARDS_MANAGER> "getProviderEligibilityOracle()(address)" --rpc-url
 
 **Pass Criteria**:
 
-- Returns the REO proxy address
+- Returns the configured eligibility oracle. On Arbitrum Sepolia the RewardsManager points at the mock (`0x69b0f3c6a19beaf1ba59405f7179e188c64b4e06`) by default; with the production REO wired in it returns the REO proxy (`0x6ba849fbd33257162552578b2a432d30784f2f80`).
 
 ---
 
@@ -366,7 +366,7 @@ cast call <REO_PROXY> "getLastOracleUpdateTime()(uint256)" --rpc-url <RPC>
 
 **Pass Criteria**:
 
-- Transaction succeeds, returns count `1`
+- Transaction succeeds and updates 1 indexer (the `uint256` return value; observe it as one `IndexerEligibilityRenewed` event — `cast send` does not surface return values)
 - `getEligibilityRenewalTime` is approximately `block.timestamp` of the renewal tx
 - `lastOracleUpdateTime` updated to the same timestamp
 - Events emitted correctly
@@ -387,7 +387,7 @@ cast send <REO_PROXY> "renewIndexerEligibility(address[],bytes)" "[<INDEXER_1>,<
 
 **Pass Criteria**:
 
-- Transaction succeeds, returns count `3`
+- Transaction succeeds and updates 3 indexers (the `uint256` return; observe three `IndexerEligibilityRenewed` events)
 - All three indexers have updated renewal timestamps
 - One `IndexerEligibilityRenewed` event per indexer
 
@@ -405,7 +405,7 @@ cast send <REO_PROXY> "renewIndexerEligibility(address[],bytes)" "[0x00000000000
 
 **Pass Criteria**:
 
-- Transaction succeeds, returns count `1` (not 2)
+- Transaction succeeds and updates 1 indexer, not 2 (the zero address is skipped)
 - Only the non-zero indexer has a `IndexerEligibilityRenewed` event
 
 ---
@@ -940,7 +940,7 @@ cast send <REO_PROXY> "unpause()" --rpc-url <RPC> --private-key <PAUSE_KEY>
 
 - Pause succeeds, `paused()` = `true`
 - View functions (`isEligible`) still return results
-- Oracle write operations (`renewIndexerEligibility`) revert while paused
+- `paused()` is a status flag only — the REO has no pause-gated functions, so `renewIndexerEligibility` and other writes still succeed while paused (verify the flag flips, not that writes revert)
 - Unpause succeeds, `paused()` = `false`
 
 ---

packages/issuance/docs/testing/reo/RewardsConditionsTestPlan.md

@@ -778,4 +778,4 @@ cast logs --from-block <TX_BLOCK> --to-block <TX_BLOCK> --address <REWARDS_MANAG
 
 ---
 
-_Derived from issuance upgrade behavior changes. Source: [RewardsBehaviourChanges.md](/docs/RewardsBehaviourChanges.md), [RewardConditions.md](/docs/RewardConditions.md). Contracts: `packages/contracts/contracts/rewards/RewardsManager.sol`, `packages/subgraph-service/contracts/utilities/AllocationManager.sol`._
+_Derived from issuance upgrade behavior changes. Contracts: `packages/contracts/contracts/rewards/RewardsManager.sol`, `packages/subgraph-service/contracts/libraries/AllocationHandler.sol` (POI presentation / condition handling)._

packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md

@@ -54,22 +54,25 @@ Tests for the subgraph denial behavior changes introduced in the issuance upgrad
 - [Baseline tests](BaselineTestPlan.md) Cycles 1-7 pass
 - [Reclaim system configured](RewardsConditionsTestPlan.md#cycle-1-reclaim-system-configuration) (Cycle 1 of RewardsConditionsTestPlan) — or configure inline during Cycle 1 below
 - At least two indexers with active allocations on rewarded subgraph deployments
-- Access to the Governor or SubgraphAvailabilityOracle (SAO) account that can call `setDenied()`
+- Access to the SubgraphAvailabilityOracle (SAO) account that can call `setDenied()`
 - Allocations must be mature (open for 2+ epochs) before denial tests
 
 ### Roles Needed
 
-| Role            | Needed For                                    | Holder                           |
-| --------------- | --------------------------------------------- | -------------------------------- |
-| Governor or SAO | `setDenied()` calls                           | Check Controller configuration   |
-| Governor        | `setReclaimAddress()` (if not yet configured) | Council/NetworkOperator multisig |
+| Role     | Needed For                                    | Holder                                         |
+| -------- | --------------------------------------------- | ---------------------------------------------- |
+| SAO      | `setDenied()` calls                           | `subgraphAvailabilityOracle` on RewardsManager |
+| Governor | `setReclaimAddress()` (if not yet configured) | Council/NetworkOperator multisig               |
 
 ### Identifying the SAO
 
 ```bash
-# The SAO is stored in the Controller as the subgraphAvailabilityOracle
-# Alternatively, check who can call setDenied on RewardsManager
-cast call <CONTROLLER> "getContractProxy(bytes32)(address)" $(cast keccak "SubgraphAvailabilityOracle") --rpc-url <RPC>
+# The SAO is a storage variable on RewardsManager (NOT a Controller-registered proxy).
+# Note: on a full deployment this is typically the SubgraphAvailabilityManager voting
+# contract, where oracles call vote()/voteMany() to reach the denial threshold rather
+# than calling setDenied() directly. The cast send steps below assume the SAO is an EOA
+# you control — confirm the returned address is an EOA before following them.
+cast call <REWARDS_MANAGER> "subgraphAvailabilityOracle()(address)" --rpc-url <RPC>
 ```
 
 ---
@@ -93,7 +96,7 @@ cast call <CONTROLLER> "getContractProxy(bytes32)(address)" $(cast keccak "Subgr
 | Cycle | Area                            | Tests     | Notes                                              |
 | ----- | ------------------------------- | --------- | -------------------------------------------------- |
 | 1     | Reclaim Setup for Denial        | 1.1 - 1.2 | Governor access needed; skip if already configured |
-| 2     | Denial State Management         | 2.1 - 2.4 | SAO or Governor access needed                      |
+| 2     | Denial State Management         | 2.1 - 2.4 | SAO access needed                                  |
 | 3     | Accumulator Freeze Verification | 3.1 - 3.4 | Read-only after denial; wait for epochs            |
 | 4     | Allocation-Level Deferral       | 4.1 - 4.3 | Requires active allocations on denied subgraph     |
 | 5     | Undeny and Reward Recovery      | 5.1 - 5.4 | Full deny→undeny→claim lifecycle                   |
@@ -180,7 +183,7 @@ cast call <REWARDS_MANAGER> "getAccRewardsPerAllocatedToken(bytes32)(uint256,uin
 **Steps**:
 
 ```bash
-# Deny the subgraph (as SAO or Governor)
+# Deny the subgraph (as SAO)
 cast send <REWARDS_MANAGER> "setDenied(bytes32,bool)" <SUBGRAPH_DEPLOYMENT_ID> true --rpc-url <RPC> --private-key <SAO_KEY>
 
 # Verify denial
@@ -226,7 +229,7 @@ cast call <REWARDS_MANAGER> "isDenied(bytes32)(bool)" <SUBGRAPH_DEPLOYMENT_ID> -
 
 ### 2.4 Unauthorized deny reverts
 
-**Objective**: Only the SAO or Governor can deny subgraphs.
+**Objective**: Only the SAO can deny subgraphs (a Governor-keyed call also reverts).
 
 **Steps**:
 
@@ -677,4 +680,4 @@ cast call <REWARDS_MANAGER> "isDenied(bytes32)(bool)" <SUBGRAPH_DEPLOYMENT_ID> -
 
 ---
 
-_Derived from issuance upgrade behavior changes. Source: [RewardsBehaviourChanges.md](/docs/RewardsBehaviourChanges.md), [RewardConditions.md](/docs/RewardConditions.md). Contract: `packages/contracts/contracts/rewards/RewardsManager.sol`, `packages/subgraph-service/contracts/utilities/AllocationManager.sol`._
+_Derived from issuance upgrade behavior changes. Contracts: `packages/contracts/contracts/rewards/RewardsManager.sol`, `packages/subgraph-service/contracts/libraries/AllocationHandler.sol` (POI deferral)._

packages/issuance/docs/testing/reo/TestnetDetails.md

@@ -15,7 +15,7 @@
 
 ## Network Subgraph
 
-**Query via Graph Explorer**: [Graph Network Arbitrum Sepolia](https://thegraph.com/explorer/subgraphs/3xQHhMudr1oh69ut36G2mbzpYmYxwqCeU6wwqyCDCnqV?view=Query&chain=arbitrum-one)
+**Query via Graph Explorer**: [Graph Network Arbitrum Sepolia](https://thegraph.com/explorer/subgraphs/3xQHhMudr1oh69ut36G2mbzpYmYxwqCeU6wwqyCDCnqV?view=Query)
 
 Or query directly:
 

packages/issuance/docs/testing/reo/support/IssuanceAllocatorTestPlan.md

@@ -2,15 +2,13 @@
 
 > **Navigation**: [← Back to REO Testing](../README.md)
 
-Separated from the REO test plan — IssuanceAllocator is independent of the Rewards Eligibility Oracle. Test when deployed.
-
 ## Contract Addresses
 
-| Contract                  | Arbitrum Sepolia                             | Arbitrum One |
-| ------------------------- | -------------------------------------------- | ------------ |
-| IssuanceAllocator (proxy) | Not yet deployed                             | TBD          |
-| RewardsManager (proxy)    | `0x1f49cae7669086c8ba53cc35d1e9f80176d67e79` | TBD          |
-| GraphToken (L2)           | `0xf8c05dcf59e8b28bfd5eed176c562bebcfc7ac04` | TBD          |
+| Contract                  | Arbitrum Sepolia                             | Arbitrum One                                 |
+| ------------------------- | -------------------------------------------- | -------------------------------------------- |
+| IssuanceAllocator (proxy) | `0x76a0d75651d4db83f74ac502b86a0ae4e19ac38b` | Not yet deployed                             |
+| RewardsManager (proxy)    | `0x1f49cae7669086c8ba53cc35d1e9f80176d67e79` | `0x971b9d3d0ae3eca029cab5ea1fb0f72c85e6a525` |
+| GraphToken (L2)           | `0xf8c05dcf59e8b28bfd5eed176c562bebcfc7ac04` | `0x9623063377ad1b27544c965ccd7342f7ea7e88c7` |
 
 ---
 
@@ -27,7 +25,9 @@ Separated from the REO test plan — IssuanceAllocator is independent of the Rew
 cast call <ISSUANCE_ALLOCATOR> "getIssuancePerBlock()(uint256)" --rpc-url <RPC>
 
 # Check RewardsManager target allocation
-cast call <ISSUANCE_ALLOCATOR> "getTargetIssuancePerBlock(address)(uint256,uint256)" <REWARDS_MANAGER> --rpc-url <RPC>
+# Returns a TargetIssuancePerBlock struct:
+# (allocatorIssuanceRate, allocatorIssuanceBlockAppliedTo, selfIssuanceRate, selfIssuanceBlockAppliedTo)
+cast call <ISSUANCE_ALLOCATOR> "getTargetIssuancePerBlock(address)((uint256,uint256,uint256,uint256))" <REWARDS_MANAGER> --rpc-url <RPC>
 
 # Check if IssuanceAllocator is minter
 cast call <GRAPH_TOKEN> "isMinter(address)(bool)" <ISSUANCE_ALLOCATOR> --rpc-url <RPC>

packages/issuance/docs/testing/reo/support/NotionTracker.csv

@@ -32,7 +32,7 @@ E-5.1,Eligibility,Verify eligibility when validation is off,https://github.com/g
 D-1.1,Denial,Configure SUBGRAPH_DENIED reclaim address,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#11-configure-subgraph_denied-reclaim-address,,,,Not Started,Governor access needed
 D-1.2,Denial,Record reclaim address GRT balance,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#12-record-reclaim-address-grt-balance,,,,Not Started,
 D-2.1,Denial,Verify subgraph is not denied (pre-test),https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#21-verify-subgraph-is-not-denied-pre-test,,,,Not Started,Record accumulator baseline
-D-2.2,Denial,Deny subgraph deployment,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#22-deny-subgraph-deployment,,,,Not Started,SAO or Governor access needed
+D-2.2,Denial,Deny subgraph deployment,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#22-deny-subgraph-deployment,,,,Not Started,SAO access needed
 D-2.3,Denial,Redundant deny is idempotent,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#23-redundant-deny-is-idempotent,,,,Not Started,
 D-2.4,Denial,Unauthorized deny reverts,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#24-unauthorized-deny-reverts,,,,Not Started,
 D-3.1,Denial,Accumulators freeze after denial,https://github.com/graphprotocol/contracts/blob/reo-testing/packages/issuance/docs/testing/reo/SubgraphDenialTestPlan.md#31-accumulators-freeze-after-denial,,,,Not Started,Wait 30+ min after denial