Skip to content

Indexing payments management audit fix 2 #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RembrandtK wants to merge 31 commits into
base: indexing-payments-management-audit-fix-reduced
Choose a base branch
from

feat(contracts): add getIssuanceAllocator to IIssuanceTarget interface

a9c2737
Select commit
Loading
Failed to load commit list.
Draft

Indexing payments management audit fix 2 #1323

feat(contracts): add getIssuanceAllocator to IIssuanceTarget interface
a9c2737
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 23, 2026 in 1s

91.04% (+0.18%) compared to 0bbb476

View this Pull Request on Codecov

91.04% (+0.18%) compared to 0bbb476

Details

Codecov Report

❌ Patch coverage is 98.32636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.04%. Comparing base (0bbb476) to head (a9c2737).

Files with missing lines Patch % Lines
...ntracts/payments/collectors/RecurringCollector.sol 98.33% 2 Missing and 1 partial ⚠️
...-service/contracts/libraries/IndexingAgreement.sol 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                                Coverage Diff                                 @@
##           indexing-payments-management-audit-fix-reduced    #1323      +/-   ##
==================================================================================
+ Coverage                                           90.86%   91.04%   +0.18%     
==================================================================================
  Files                                                  81       81              
  Lines                                                5274     5317      +43     
  Branches                                              949      964      +15     
==================================================================================
+ Hits                                                 4792     4841      +49     
+ Misses                                                453      451       -2     
+ Partials                                               29       25       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov