Skip to content

Indexing payments management audit fix 2 light #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RembrandtK wants to merge 37 commits into
base: indexing-payments-management-audit-fix-reduced
Choose a base branch
from

fix(collector): use dedicated error for invalid offer type in offer()

757da41
Select commit
Loading
Failed to load commit list.
Open

Indexing payments management audit fix 2 light #1325

fix(collector): use dedicated error for invalid offer type in offer()
757da41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 27, 2026 in 1s

91.15% (+2.59%) compared to ddee12b

View this Pull Request on Codecov

91.15% (+2.59%) compared to ddee12b

Details

Codecov Report

❌ Patch coverage is 99.06015% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.15%. Comparing base (ddee12b) to head (757da41).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ntracts/payments/collectors/RecurringCollector.sol 99.18% 3 Missing ⚠️
...ges/contracts/contracts/rewards/RewardsManager.sol 96.42% 1 Missing ⚠️
...n/contracts/data-service/libraries/StakeClaims.sol 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   88.55%   91.15%   +2.59%     
==========================================
  Files          75       81       +6     
  Lines        4615     5337     +722     
  Branches      981      973       -8     
==========================================
+ Hits         4087     4865     +778     
+ Misses        507      449      -58     
- Partials       21       23       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov