docs: update GraphTally docs#1002
Merged
Merged
Conversation
benface
requested changes
Jul 9, 2025
Contributor
benface
left a comment
There was a problem hiding this comment.
Hey, looks like you updated the file in the wrong language (pages/es instead of pages/en). Also, there are weird formatting changes – I recommend running pnpm check:fix after making changes (but before committing them), if you don't have the Prettier extension installed and format on save enabled.
idalithb
reviewed
Jul 9, 2025
Contributor
idalithb
left a comment
There was a problem hiding this comment.
- Minor suggested edits, but LGTM!
- Happy with the reorganization of this 😄
| - [Graph TAP Arbitrum One Subgraph (for The Graph mainnet)](https://thegraph.com/explorer/subgraphs/4sukbNVTzGELnhdnpyPqsf1QqtzNHEYKKmJkgaT8z6M1) | ||
|
|
||
| > Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. As a result, you have to index it manually. | ||
| > Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually. |
Contributor
There was a problem hiding this comment.
Suggested change
| > Note: `indexer-agent` does not currently handle the indexing of this subgraph like it does for the network subgraph deployment. You must index it manually. | |
| > Note: `indexer-agent` does not currently handle the indexing of this Subgraph like it does for the network Subgraph deployment. You must index it manually. |
- the style guide will be updated to reflect cap preference
| # Locally indexing the Subgraph is recommended. | ||
| # NOTE: Use `query_url` or `deployment_id` only | ||
| deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" | ||
| # The Graph Network subgraph (use query_url OR deployment_id, not both) |
Contributor
There was a problem hiding this comment.
Suggested change
| # The Graph Network subgraph (use query_url OR deployment_id, not both) | |
| # The Graph Network Subgraph (use query_url OR deployment_id, not both) |
| # Locally indexing the Subgraph is recommended. | ||
| # NOTE: Use `query_url` or `deployment_id` only | ||
| deployment_id = "Qmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" | ||
| # TAP Escrow subgraph (use query_url OR deployment_id, not both) |
Contributor
There was a problem hiding this comment.
Suggested change
| # TAP Escrow subgraph (use query_url OR deployment_id, not both) | |
| # TAP Escrow Subgraph (use query_url OR deployment_id, not both) |
idalithb
approved these changes
Jul 9, 2025
Signed-off-by: Joseph Livesey <joseph@semiotic.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @matthewdarwin for flagging the need for an update!
Signed off by Joseph Livesey joseph@semiotic.ai