Closed
Conversation
benface
reviewed
Mar 31, 2025
Contributor
benface
left a comment
benface
left a comment
There was a problem hiding this comment.
Hey @MichaelMacaulay, did you run the fix-pages-structure script (or run pnpm run build which runs that script on pre-build) by any chance? Because we should avoid duplicating changes in all languages in PRs; it makes it harder / more confusing to review and address feedback.
benface
requested changes
Mar 31, 2025
Contributor
benface
left a comment
benface
left a comment
There was a problem hiding this comment.
Also, looks like some images referenced in MDX files are missing, making the build fail.
Contributor
Author
|
@benface yes, I ran fix-pages-structure |
Contributor
|
Ah ok, you shouldn't run that manually except maybe right before merging a PR, but even then, we can just run it in a separate branch / PR at some point. That script is run manually before build in CI/CD so not running it will not make the build / deployment fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.