graph, store: propagate skip_duplicates to RowGroup

Add skip_duplicates: bool field to RowGroup struct alongside immutable,
update RowGroup::new() to accept the parameter, and wire it from
entity_type.skip_duplicates() in RowGroups::group_entry(). All other
call sites (RowGroupForPerfTest, test helpers, example) pass false.

Author: isum

graph/examples/append_row.rs

@@ -104,7 +104,7 @@ pub fn main() -> anyhow::Result<()> {
             };
             mods.push(md);
         }
-        let mut group = RowGroup::new(THING_TYPE.clone(), false);
+        let mut group = RowGroup::new(THING_TYPE.clone(), false, false);
 
         let start = Instant::now();
         for md in mods {

graph/src/components/store/write.rs

@@ -344,18 +344,20 @@ pub struct RowGroup {
     rows: Vec<EntityModification>,
 
     immutable: bool,
+    skip_duplicates: bool,
 
     /// Map the `key.entity_id` of all entries in `rows` to the index with
     /// the most recent entry for that id to speed up lookups.
     last_mod: LastMod,
 }
 
 impl RowGroup {
-    pub fn new(entity_type: EntityType, immutable: bool) -> Self {
+    pub fn new(entity_type: EntityType, immutable: bool, skip_duplicates: bool) -> Self {
         Self {
             entity_type,
             rows: Vec::new(),
             immutable,
+            skip_duplicates,
             last_mod: LastMod::new(),
         }
     }
@@ -604,8 +606,8 @@ impl RowGroup {
 pub struct RowGroupForPerfTest(RowGroup);
 
 impl RowGroupForPerfTest {
-    pub fn new(entity_type: EntityType, immutable: bool) -> Self {
-        Self(RowGroup::new(entity_type, immutable))
+    pub fn new(entity_type: EntityType, immutable: bool, skip_duplicates: bool) -> Self {
+        Self(RowGroup::new(entity_type, immutable, skip_duplicates))
     }
 
     pub fn push(&mut self, emod: EntityModification, block: BlockNumber) -> Result<(), StoreError> {
@@ -685,8 +687,12 @@ impl RowGroups {
             Some(pos) => &mut self.groups[pos],
             None => {
                 let immutable = entity_type.is_immutable();
-                self.groups
-                    .push(RowGroup::new(entity_type.clone(), immutable));
+                let skip_duplicates = entity_type.skip_duplicates();
+                self.groups.push(RowGroup::new(
+                    entity_type.clone(),
+                    immutable,
+                    skip_duplicates,
+                ));
                 // unwrap: we just pushed an entry
                 self.groups.last_mut().unwrap()
             }
@@ -1080,6 +1086,7 @@ mod test {
             entity_type: ENTRY_TYPE.clone(),
             rows,
             immutable: false,
+            skip_duplicates: false,
             last_mod,
         };
         let act = group
@@ -1187,7 +1194,7 @@ mod test {
     impl Group {
         fn new() -> Self {
             Self {
-                group: RowGroup::new(THING_TYPE.clone(), false),
+                group: RowGroup::new(THING_TYPE.clone(), false, false),
             }
         }
 

store/test-store/tests/postgres/relational.rs

@@ -996,7 +996,7 @@ async fn conflicting_entity() {
             let fred = entity! { layout.input_schema => id: id.clone(), name: id.clone() };
             let fred = Arc::new(fred);
             let types: Vec<_> = types.into_iter().cloned().collect();
-            let mut group = RowGroup::new(entity_type.clone(), false);
+            let mut group = RowGroup::new(entity_type.clone(), false, false);
             group
                 .push(
                     EntityModification::Insert {

store/test-store/tests/postgres/relational_bytes.rs

@@ -85,7 +85,7 @@ pub fn row_group_update(
     block: BlockNumber,
     data: impl IntoIterator<Item = (EntityKey, Entity)>,
 ) -> RowGroup {
-    let mut group = RowGroup::new(entity_type.clone(), false);
+    let mut group = RowGroup::new(entity_type.clone(), false, false);
     for (key, data) in data {
         group
             .push(EntityModification::overwrite(key, data, block), block)
@@ -99,7 +99,7 @@ pub fn row_group_insert(
     block: BlockNumber,
     data: impl IntoIterator<Item = (EntityKey, Entity)>,
 ) -> RowGroup {
-    let mut group = RowGroup::new(entity_type.clone(), false);
+    let mut group = RowGroup::new(entity_type.clone(), false, false);
     for (key, data) in data {
         group
             .push(EntityModification::insert(key, data, block), block)
@@ -113,7 +113,7 @@ pub fn row_group_delete(
     block: BlockNumber,
     data: impl IntoIterator<Item = EntityKey>,
 ) -> RowGroup {
-    let mut group = RowGroup::new(entity_type.clone(), false);
+    let mut group = RowGroup::new(entity_type.clone(), false, false);
     for key in data {
         group
             .push(EntityModification::remove(key, block), block)