store: Refactor clear_stale_call_cache

Refactor the code to separate the gymnastics caused by the two separate
storage schemes from the overall control loop

Author: lutter

graph/src/blockchain/mock.rs

@@ -594,8 +594,8 @@ impl ChainStore for MockChainStore {
     }
     async fn clear_stale_call_cache(
         &self,
-        _ttl_days: i32,
-        _ttl_max_contracts: Option<i64>,
+        _ttl_days: usize,
+        _ttl_max_contracts: Option<usize>,
     ) -> Result<(), Error> {
         unimplemented!()
     }

graph/src/components/store/traits.rs

@@ -660,8 +660,8 @@ pub trait ChainStore: ChainHeadStore {
     /// Clears stale call cache entries for the given TTL in days.
     async fn clear_stale_call_cache(
         &self,
-        ttl_days: i32,
-        ttl_max_contracts: Option<i64>,
+        ttl_days: usize,
+        ttl_max_contracts: Option<usize>,
     ) -> Result<(), Error>;
 
     /// Return the chain identifier for this store.

node/src/bin/manager.rs

@@ -619,11 +619,11 @@ pub enum CallCacheCommand {
         #[clap(long, conflicts_with_all = &["from", "to"])]
         remove_entire_cache: bool,
         /// Remove the cache for contracts that have not been accessed in the last <TTL_DAYS> days
-        #[clap(long, conflicts_with_all = &["from", "to", "remove-entire-cache"], value_parser = clap::value_parser!(i32).range(1..))]
-        ttl_days: Option<i32>,
+        #[clap(long, conflicts_with_all = &["from", "to", "remove-entire-cache"], value_parser = clap::value_parser!(u32).range(1..))]
+        ttl_days: Option<usize>,
         /// Limits the number of contracts to consider for cache removal when using --ttl_days
-        #[clap(long, conflicts_with_all = &["remove-entire-cache", "to", "from"], requires = "ttl_days", value_parser = clap::value_parser!(i64).range(1..))]
-        ttl_max_contracts: Option<i64>,
+        #[clap(long, conflicts_with_all = &["remove-entire-cache", "to", "from"], requires = "ttl_days", value_parser = clap::value_parser!(u64).range(1..))]
+        ttl_max_contracts: Option<usize>,
         /// Starting block number
         #[clap(long, short, conflicts_with = "remove-entire-cache", requires = "to")]
         from: Option<i32>,

node/src/manager/commands/chain.rs

@@ -83,8 +83,8 @@ pub async fn clear_call_cache(
 
 pub async fn clear_stale_call_cache(
     chain_store: Arc<ChainStore>,
-    ttl_days: i32,
-    ttl_max_contracts: Option<i64>,
+    ttl_days: usize,
+    ttl_max_contracts: Option<usize>,
 ) -> Result<(), Error> {
     println!(
         "Removing stale entries from the call cache for `{}`",