chain: Do not use the block cache for is_on_main_chain#6537
Merged
incrypto32 merged 1 commit intomasterfrom Apr 23, 2026
Merged
chain: Do not use the block cache for is_on_main_chain#6537incrypto32 merged 1 commit intomasterfrom
incrypto32 merged 1 commit intomasterfrom
Conversation
Partially reverts #6491
incrypto32
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is tempting to use the block cache here; but that can go wrong when graph-node gets shut down and some of its nonfinal blocks then are reorged; when graph-node gets started again when those block numbers have become final, it might consider a reorged block as canonical; allowing the use of the block cache here would require us to also track the finality of blocks.
Partially reverts #6491