fix parsing bug

Author: nikgraf

.changeset/fix-number-property-parsing.md

@@ -0,0 +1,5 @@
+---
+"@graphprotocol/hypergraph": patch
+---
+
+fix number property parsing when API returns value as string

.claude/settings.local.json

@@ -1,6 +1,12 @@
 {
   "permissions": {
-    "allow": ["Bash(pnpm lint:fix:*)", "Bash(pnpm typecheck:*)", "Bash(pnpm check:*)"],
+    "allow": [
+      "Bash(pnpm lint:fix:*)",
+      "Bash(pnpm typecheck:*)",
+      "Bash(pnpm check:*)",
+      "Bash(pnpm --filter events test:script:*)",
+      "Bash(pnpm test:*)"
+    ],
     "deny": [],
     "ask": []
   }

apps/events/package.json

@@ -6,7 +6,8 @@
   "scripts": {
     "dev": "vite --force",
     "preview": "vite preview",
-    "typesync": "hypergraph typesync"
+    "typesync": "hypergraph typesync",
+    "test:script": "tsx test-script.ts"
   },
   "dependencies": {
     "@graphprotocol/grc-20": "^0.27.0",

apps/events/test-script.ts

@@ -0,0 +1,33 @@
+import { SystemIds } from '@graphprotocol/grc-20';
+import { Config, Entity, Id, Type } from '@graphprotocol/hypergraph';
+
+Config.setApiOrigin('https://testnet-api.geobrowser.io');
+
+const BOUNTY_TYPE_ID = Id('327976dea5ad45769b83b7e7ec6337cf');
+const REWARD_PROPERTY_ID = Id('e8e7301136354e84b46b767e7cd530a8');
+
+const Bounty = Entity.Schema(
+  {
+    name: Type.String,
+    description: Type.String,
+    reward: Type.Number,
+  },
+  {
+    types: [BOUNTY_TYPE_ID],
+    properties: {
+      name: SystemIds.NAME_PROPERTY,
+      description: SystemIds.DESCRIPTION_PROPERTY,
+      reward: REWARD_PROPERTY_ID,
+    },
+  },
+);
+
+async function main() {
+  const bounty = await Entity.findOnePublic(Bounty, {
+    id: '93c9d09e662840a891fefe4c505f9365',
+    space: 'b0043a26cb81379c1217dfd2283b67b8',
+  });
+  console.log(bounty);
+}
+
+main();

packages/hypergraph/src/entity/find-many-public.ts

@@ -165,7 +165,7 @@ export const parseResult = <S extends Schema.Schema.AnyNoContext, IncludeSpaceId
         const value = queryEntity.valuesList.find((a) => a.propertyId === result.value);
         if (value) {
           const rawValue = Utils.convertPropertyValue(value, propType);
-          if (rawValue) {
+          if (rawValue !== undefined) {
             rawEntity[String(prop.name)] = rawValue;
           }
         }

packages/hypergraph/src/entity/find-one-public.ts

@@ -97,7 +97,7 @@ const parseResult = <S extends Schema.Schema.AnyNoContext, IncludeSpaceIds exten
       const value = queryEntity.valuesList.find((a) => a.propertyId === result.value);
       if (value) {
         const rawValue = Utils.convertPropertyValue(value, propType);
-        if (rawValue) {
+        if (rawValue !== undefined) {
           rawEntity[String(prop.name)] = rawValue;
         }
       }

packages/hypergraph/src/utils/convert-property-value.ts

@@ -18,7 +18,14 @@ export const convertPropertyValue = (
       return property.point;
     }
     if (propertyType.value === 'number') {
-      return Number(property.number);
+      // Handle case where number is stored as string in the API
+      if (property.number != null) {
+        return Number(property.number);
+      }
+      if (property.string != null) {
+        return Number(property.string);
+      }
+      return undefined;
     }
     if (propertyType.value === 'date') {
       return property.time;

packages/hypergraph/src/utils/convert-relations.ts

@@ -150,7 +150,7 @@ export const convertRelations = <_S extends Schema.Schema.AnyNoContext>(
                 continue;
               }
               const rawValue = convertPropertyValue(value, propType);
-              if (rawValue) {
+              if (rawValue !== undefined) {
                 nestedRawEntity[String(nestedProp.name)] = rawValue;
               }
             }