Skip to content

Ng/connect fixes - #257

Merged
nikgraf merged 3 commits into
mainfrom
ng/connect-fixes
Jun 25, 2025
Merged

Ng/connect fixes#257
nikgraf merged 3 commits into
mainfrom
ng/connect-fixes

Conversation

@nikgraf

@nikgraf nikgraf commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@nikgraf
nikgraf requested a review from Copilot June 25, 2025 14:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues in the Connect module by merging public spaces data into the authenticate view and refactoring the CreateSpaceCard component to support both private and public space creation.

  • Merges publicSpacesData with privateSpacesData in the authenticate route
  • Splits the space creation logic into separate functions for public and private spaces and introduces a new select input
  • Adds a new dependency (@graphprotocol/grc-20) to support public space creation

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
apps/connect/src/routes/authenticate.tsx Merges private and public spaces data for display
apps/connect/src/components/CreateSpaceCard.tsx Refactors space creation functionality and UI
apps/connect/package.json Adds dependency for public space creation
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

<div className="relative min-h-80 lg:col-2">
<SpacesCard
spaces={privateSpacesData ?? []}
spaces={[...(privateSpacesData ?? []), ...(publicSpacesData ?? [])]}

Copilot AI Jun 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging privateSpacesData and publicSpacesData, consider whether duplicate entries could be introduced if a space appears in both arrays. If duplicates are possible, add filtering logic to ensure data consistency.

Suggested change
spaces={[...(privateSpacesData ?? []), ...(publicSpacesData ?? [])]}
spaces={[
...new Map(
[...(privateSpacesData ?? []), ...(publicSpacesData ?? [])].map(space => [space.id, space])
).values()
]}

Copilot uses AI. Check for mistakes.
const createSpace = async () => {
const createPublicSpace = async () => {
if (!accountAddress) {
alert('Missing account address');

Copilot AI Jun 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error notifications are handled differently between createPublicSpace (using alerts) and createPrivateSpace (logging to console). Consider using a consistent error messaging strategy to enhance user experience and maintain consistency.

Suggested change
alert('Missing account address');
setErrorMessage('Missing account address');

Copilot uses AI. Check for mistakes.
@nikgraf
nikgraf merged commit 0a45cae into main Jun 25, 2025
6 checks passed
@nikgraf
nikgraf deleted the ng/connect-fixes branch June 25, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants