fix verifyIdentityOwnership - #263
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors identity verification by requiring explicit network configuration parameters (chain and rpcUrl) in multiple functions.
- Added chain and rpcUrl parameters to validateSpaceInboxMessage, validateAccountInboxMessage, getVerifiedIdentity, and verifyIdentityOwnership.
- Adjusted import orders and updated the HypergraphAppContext to provide CHAIN and RPC_URL constants for consistency.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hypergraph/src/inboxes/message-validation.ts | Added chain and rpcUrl parameters to message validation functions and updated getVerifiedIdentity calls. |
| packages/hypergraph/src/identity/prove-ownership.ts | Removed default parameters for chain and rpcUrl in verifyIdentityOwnership and reordered imports. |
| packages/hypergraph/src/identity/get-verified-identity.ts | Extended getVerifiedIdentity with chain and rpcUrl parameters, passing them to verifyIdentityOwnership. |
| packages/hypergraph-react/src/HypergraphAppContext.tsx | Introduced CHAIN and RPC_URL constants and updated identity verification calls accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.