fix publishing - #287
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix publishing issues by updating entity creation and updating space IDs across the Hypergraph-related modules.
- Adds an "id" property when creating an entity via Graph.createEntity
- Updates space identifiers in the playground routes and components for consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/hypergraph-react/src/prepare-publish.ts | Adds the entity id to the createEntity payload |
| apps/events/src/routes/playground.lazy.tsx | Updates the space ID in the HypergraphSpaceProvider and related components |
| apps/events/src/components/playground.tsx | Updates the space ID for delete and create entity hooks |
Comments suppressed due to low confidence (1)
packages/hypergraph-react/src/prepare-publish.ts:94
- Confirm that adding the id property in the Graph.createEntity payload is supported by the API and that it will not lead to duplicate or unintended id assignments.
id: entity.id,
| function RouteComponent() { | ||
| return ( | ||
| <HypergraphSpaceProvider space="d9814a82-8dab-4d02-86d2-9d413f7dc336"> | ||
| <HypergraphSpaceProvider space="a57cd482-6dd3-4ba3-ac44-e2e8ea7a2862"> |
There was a problem hiding this comment.
[nitpick] Consider extracting the space ID literal into a shared constant or configuration file to improve maintainability and reduce duplication.
Comment on lines
+25
to
+29
| space: 'a57cd482-6dd3-4ba3-ac44-e2e8ea7a2862', | ||
| }); | ||
|
|
||
| const createEntity = _useCreateEntityPublic(Event, { | ||
| space: '1c954768-7e14-4f0f-9396-0fe9dcd55fe8', | ||
| space: 'a57cd482-6dd3-4ba3-ac44-e2e8ea7a2862', |
There was a problem hiding this comment.
[nitpick] Consider extracting the space ID literal into a shared constant or configuration file to ensure consistency across the codebase and ease future updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.