fix(logging): forbid pino reserved keys as per-call log fields

Add an eslint rule across the agent, common and cli packages banning pino's reserved keys
(name, level, time, pid, hostname, msg, v) as per-call log fields, which silently emit a
duplicate JSON key. It caught two more real collisions (a `name` and a `msg`), fixed here too.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJmMVG736T3xefovirWryK

Author: MoonBoi9001

packages/indexer-agent/.eslintrc.js

@@ -2,5 +2,18 @@ module.exports = {
   root: true,
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint'],
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier']
+  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  rules: {
+    // Pino emits a per-call field whose key matches a logger binding as a SECOND JSON
+    // key; strict parsers keep only the last. Forbid pino reserved keys as per-call fields.
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector:
+          "CallExpression[callee.property.name=/^(trace|debug|info|warn|error|fatal)$/] > ObjectExpression > Property[key.name=/^(name|level|time|pid|hostname|msg|v)$/]",
+        message:
+          'Do not pass a pino reserved key (name, level, time, pid, hostname, msg, v) as a per-call log field: it collides with the logger bindings and emits a duplicate JSON key that strict parsers silently drop. Use a distinct key (e.g. subgraphName) or set bindings via logger.child({ ... }).',
+      },
+    ],
+  },
 }

packages/indexer-agent/src/db/cli/umzug.ts

@@ -50,7 +50,7 @@ const sequelize = new Sequelize({
   logging: false,
 })
 
-logger.debug('Successfully connected to DB', { name: database })
+logger.debug('Successfully connected to DB', { database })
 
 export const migrator = new Umzug({
   migrations: {

packages/indexer-cli/.eslintrc.js

@@ -2,5 +2,18 @@ module.exports = {
   root: false,
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint'],
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier']
+  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  rules: {
+    // Pino emits a per-call field whose key matches a logger binding as a SECOND JSON
+    // key; strict parsers keep only the last. Forbid pino reserved keys as per-call fields.
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector:
+          "CallExpression[callee.property.name=/^(trace|debug|info|warn|error|fatal)$/] > ObjectExpression > Property[key.name=/^(name|level|time|pid|hostname|msg|v)$/]",
+        message:
+          'Do not pass a pino reserved key (name, level, time, pid, hostname, msg, v) as a per-call log field: it collides with the logger bindings and emits a duplicate JSON key that strict parsers silently drop. Use a distinct key (e.g. subgraphName) or set bindings via logger.child({ ... }).',
+      },
+    ],
+  },
 }

packages/indexer-common/.eslintrc.js

@@ -2,5 +2,18 @@ module.exports = {
   root: false,
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint'],
-  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier']
+  extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'],
+  rules: {
+    // Pino emits a per-call field whose key matches a logger binding as a SECOND JSON
+    // key; strict parsers keep only the last. Forbid pino reserved keys as per-call fields.
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector:
+          "CallExpression[callee.property.name=/^(trace|debug|info|warn|error|fatal)$/] > ObjectExpression > Property[key.name=/^(name|level|time|pid|hostname|msg|v)$/]",
+        message:
+          'Do not pass a pino reserved key (name, level, time, pid, hostname, msg, v) as a per-call log field: it collides with the logger bindings and emits a duplicate JSON key that strict parsers silently drop. Use a distinct key (e.g. subgraphName) or set bindings via logger.child({ ... }).',
+      },
+    ],
+  },
 }

packages/indexer-common/src/indexer-management/monitor.ts

@@ -164,10 +164,8 @@ export class NetworkMonitor {
    * @returns network `alias` if the network is supported, `null` otherwise
    */
   async allocationNetworkAlias(allocation: Allocation): Promise<string | null> {
-    // TODO:
-    // resolveChainId will throw an Error when we can't resolve the chainId in
-    // the future, let's get this from the epoch subgraph (perhaps at startup)
-    // and then resolve it here.
+    // TODO: resolveChainId will throw when we can't resolve the chainId; in the future
+    // get this from the epoch subgraph (perhaps at startup) and resolve it here.
     try {
       const { network: allocationNetworkAlias } = await this.graphNode.subgraphFeatures(
         allocation.subgraphDeployment.id,
@@ -947,7 +945,7 @@ Please submit an issue at https://github.com/graphprotocol/block-oracle/issues/n
       } else {
         this.logger.error(`Failed to query latest epoch number`, {
           err,
-          msg: err.message,
+          errorMessage: err.message,
           networkID,
           networkAlias,
         })
@@ -1388,10 +1386,9 @@ Please submit an issue at https://github.com/graphprotocol/block-oracle/issues/n
       return [hexlify(new Uint8Array(32).fill(0)), 0]
     }
 
-    // poi = undefined, force=true  -- submit even if poi is 0x0
-    // poi = defined,   force=true  -- no generatedPOI needed, just submit the POI supplied (with some sanitation?)
-    // poi = undefined, force=false -- submit with generated POI if one available
-    // poi = defined,   force=false -- submit user defined POI only if generated POI matches
+    // force=true:  poi undefined -> submit even if 0x0;  poi defined -> submit the supplied POI
+    // force=false: poi undefined -> submit a generated POI if available;  poi defined -> submit the
+    //              user POI only if it matches the generated POI
     switch (force) {
       case true:
         switch (!!poi) {