perf: optimize RAV allocation lookup from O(n²) to O(n)

Replace Array.find() with Map-based lookups for constant-time allocation
retrieval in both TapCollector and GraphTallyCollector.

This achieves approximately 5000x performance improvement for datasets
with 10k+ RAVs/allocations by eliminating the nested loop that caused
quadratic complexity.

Changes:
- tap-collector.ts: Build allocation map for O(1) lookups
- graph-tally-collector.ts: Build allocation map for O(1) lookups

Based on: #1146
Original author: madumas
Original commit: 59efa95

Author: dwerner

packages/indexer-common/src/allocations/graph-tally-collector.ts

@@ -236,20 +236,30 @@ export class GraphTallyCollector {
         })
         this.logger.trace(`[TAPv2] RAW DATA`, { ravs, allocations })
 
-        const pendingRAVsToProcess = ravs
-          .map((rav) => {
-            const signedRav = rav.getSignedRAV()
-            return {
+        // Create an object for O(1) allocation lookups instead of O(n) Array.find()
+        // This optimizes performance from O(n²) to O(n) for large datasets
+        const allocationMap: { [key: string]: Allocation } = {}
+        for (let i = 0; i < allocations.length; i++) {
+          const allocation = allocations[i]
+          allocationMap[allocation.id.toLowerCase()] = allocation
+        }
+
+        const pendingRAVsToProcess: RavWithAllocation[] = []
+        for (let i = 0; i < ravs.length; i++) {
+          const rav = ravs[i]
+          const signedRav = rav.getSignedRAV()
+          const allocationId = toAddress(
+            collectionIdToAllocationId(signedRav.rav.collectionId),
+          ).toLowerCase()
+          const allocation = allocationMap[allocationId] // O(1) lookup
+          if (allocation !== undefined) {
+            pendingRAVsToProcess.push({
               rav: signedRav,
-              allocation: allocations.find(
-                (a) =>
-                  a.id ===
-                  toAddress(collectionIdToAllocationId(signedRav.rav.collectionId)),
-              ),
+              allocation: allocation,
               payer: rav.payer,
-            }
-          })
-          .filter((rav) => rav.allocation !== undefined) as RavWithAllocation[] // this is safe because we filter out undefined allocations
+            })
+          }
+        }
         this.logger.trace(`[TAPv2] Pending RAVs to process`, {
           pendingRAVsToProcess: pendingRAVsToProcess.length,
         })

packages/indexer-common/src/allocations/tap-collector.ts

@@ -216,18 +216,32 @@ export class TapCollector {
           ravs: ravs.length,
           allocations: allocations.length,
         })
-        return ravs
-          .map((rav) => {
-            const signedRav = rav.getSignedRAV()
-            return {
+
+        // Create an object for O(1) allocation lookups instead of O(n) Array.find()
+        // This optimizes performance from O(n²) to O(n) for large datasets
+        const allocationMap: { [key: string]: Allocation } = {}
+        for (let i = 0; i < allocations.length; i++) {
+          const allocation = allocations[i]
+          allocationMap[allocation.id.toLowerCase()] = allocation
+        }
+
+        const results: RavWithAllocation[] = []
+        for (let i = 0; i < ravs.length; i++) {
+          const rav = ravs[i]
+          const signedRav = rav.getSignedRAV()
+          const allocationId = toAddress(
+            signedRav.rav.allocationId.toString(),
+          ).toLowerCase()
+          const allocation = allocationMap[allocationId] // O(1) lookup
+          if (allocation !== undefined) {
+            results.push({
               rav: signedRav,
-              allocation: allocations.find(
-                (a) => a.id === toAddress(signedRav.rav.allocationId.toString()),
-              ),
+              allocation: allocation,
               sender: rav.senderAddress,
-            }
-          })
-          .filter((rav) => rav.allocation !== undefined) as RavWithAllocation[] // this is safe because we filter out undefined allocations
+            })
+          }
+        }
+        return results
       },
       {
         onError: (err) =>