fix(actions): add missing PRESENT_POI case to isValidActionInput (#1180)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: MoonBoi9001

packages/indexer-common/src/__tests__/actions.test.ts

@@ -111,6 +111,61 @@ describe('Action Validation', () => {
       expect(isValidActionInput(missingDeploymentID)).toBe(false)
     })
 
+    test('validates PRESENT_POI action', () => {
+      const validPresentPOI: ActionInput = {
+        ...baseAction,
+        type: ActionType.PRESENT_POI,
+        deploymentID: 'Qmtest',
+        allocationID: '0x1234567890123456789012345678901234567890',
+      } as ActionInput
+
+      expect(isValidActionInput(validPresentPOI)).toBe(true)
+
+      // Missing allocationID
+      const missingAllocationID: ActionInput = {
+        ...baseAction,
+        type: ActionType.PRESENT_POI,
+        deploymentID: 'Qmtest',
+      } as ActionInput
+
+      expect(isValidActionInput(missingAllocationID)).toBe(false)
+
+      // Missing deploymentID
+      const missingDeploymentID: ActionInput = {
+        ...baseAction,
+        type: ActionType.PRESENT_POI,
+        allocationID: '0x1234567890123456789012345678901234567890',
+      } as ActionInput
+
+      expect(isValidActionInput(missingDeploymentID)).toBe(false)
+
+      // With POI provided, must also have publicPOI and poiBlockNumber
+      const withPoiButMissingPublicPOI = {
+        ...baseAction,
+        type: ActionType.PRESENT_POI,
+        deploymentID: 'Qmtest',
+        allocationID: '0x1234567890123456789012345678901234567890',
+        poi: '0x' + 'ab'.repeat(32),
+        isLegacy: false,
+      }
+
+      expect(isValidActionInput(withPoiButMissingPublicPOI)).toBe(false)
+
+      // With all POI fields provided
+      const withAllPoiFields = {
+        ...baseAction,
+        type: ActionType.PRESENT_POI,
+        deploymentID: 'Qmtest',
+        allocationID: '0x1234567890123456789012345678901234567890',
+        poi: '0x' + 'ab'.repeat(32),
+        publicPOI: '0x' + 'cd'.repeat(32),
+        poiBlockNumber: 12345,
+        isLegacy: false,
+      }
+
+      expect(isValidActionInput(withAllPoiFields)).toBe(true)
+    })
+
     test('validates common required fields (source, reason, status, priority)', () => {
       // Missing status
       const missingStatus = {

packages/indexer-common/src/actions.ts

@@ -101,6 +101,18 @@ export const isValidActionInput = (
         'allocationID' in variableToCheck &&
         'amount' in variableToCheck
       break
+    case ActionType.PRESENT_POI:
+      hasActionParams =
+        'deploymentID' in variableToCheck && 'allocationID' in variableToCheck
+
+      if (!variableToCheck.isLegacy && variableToCheck.poi !== undefined) {
+        hasActionParams =
+          hasActionParams &&
+          'poi' in variableToCheck &&
+          'publicPOI' in variableToCheck &&
+          'poiBlockNumber' in variableToCheck
+      }
+      break
   }
   return (
     hasActionParams &&
@@ -164,11 +176,14 @@ export const validateActionInputs = async (
       )
     }
 
-    // Unallocate, reallocate, and resize actions must target an active allocationID
+    // Unallocate, reallocate, resize, and presentPOI actions must target an active allocationID
     if (
-      [ActionType.UNALLOCATE, ActionType.REALLOCATE, ActionType.RESIZE].includes(
-        action.type,
-      )
+      [
+        ActionType.UNALLOCATE,
+        ActionType.REALLOCATE,
+        ActionType.RESIZE,
+        ActionType.PRESENT_POI,
+      ].includes(action.type)
     ) {
       // allocationID must belong to active allocation
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion

packages/indexer-common/src/indexer-management/__tests__/resolvers/actions.test.ts

@@ -32,6 +32,8 @@ import {
   invalidReallocateAction,
   invalidUnallocateAction,
   queuedAllocateAction,
+  queuedResizeAction,
+  queuedPresentPOIAction,
   subgraphDeployment1,
   subgraphDeployment2,
   subgraphDeployment3,
@@ -871,4 +873,38 @@ describe.skip('Actions', () => {
         .toPromise(),
     ).resolves.toHaveProperty('data.updateActions', updatedExpecteds)
   })
+
+  test('Queue and retrieve resize action', async () => {
+    const inputAction = queuedResizeAction
+    const expected = await actionInputToExpected(inputAction, 1)
+
+    await expect(
+      client.mutation(QUEUE_ACTIONS_MUTATION, { actions: [inputAction] }).toPromise(),
+    ).resolves.toHaveProperty('data.queueActions', [expected])
+
+    await expect(
+      client
+        .query(ACTIONS_QUERY, {
+          filter: { status: ActionStatus.QUEUED, type: ActionType.RESIZE },
+        })
+        .toPromise(),
+    ).resolves.toHaveProperty('data.actions', [expected])
+  })
+
+  test('Queue and retrieve presentPOI action', async () => {
+    const inputAction = queuedPresentPOIAction
+    const expected = await actionInputToExpected(inputAction, 1)
+
+    await expect(
+      client.mutation(QUEUE_ACTIONS_MUTATION, { actions: [inputAction] }).toPromise(),
+    ).resolves.toHaveProperty('data.queueActions', [expected])
+
+    await expect(
+      client
+        .query(ACTIONS_QUERY, {
+          filter: { status: ActionStatus.QUEUED, type: ActionType.PRESENT_POI },
+        })
+        .toPromise(),
+    ).resolves.toHaveProperty('data.actions', [expected])
+  })
 })

packages/indexer-common/src/indexer-management/__tests__/util.ts

@@ -147,3 +147,15 @@ export const queuedResizeAction = {
   priority: 0,
   protocolNetwork: 'arbitrum-sepolia',
 } as ActionInput
+
+export const queuedPresentPOIAction = {
+  status: ActionStatus.QUEUED,
+  type: ActionType.PRESENT_POI,
+  deploymentID: subgraphDeployment1,
+  allocationID: '0x8f63930129e585c69482b56390a09b6b176f4a4c',
+  force: false,
+  source: 'indexerAgent',
+  reason: 'indexingRule',
+  priority: 0,
+  protocolNetwork: 'arbitrum-sepolia',
+} as ActionInput