fix: configurable allocation batch size, gas limit multiplier, and multicall bisection#1193
Open
cargopete wants to merge 2 commits intographprotocol:mainfrom
Open
Conversation
…lticall bisection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--auto-allocation-max-batch-sizedefault of 50 (was unbounded), capping the number of allocation operations per multicall transaction. Post-Horizon SubgraphService operations cost ~500–630K gas each; the previous unbounded default causesestimateGasto revert on indexers with large allocation sets.--gas-limit-multiplier(env:INDEXER_AGENT_GAS_LIMIT_MULTIPLIER, default1.5) to make the hardcodedestimateGasbuffer configurable.estimateGasreverts due to gas exhaustion the agent splits the batch in half and retries each half recursively, making it self-healing against block gas limit changes without requiring operator intervention. Known contract error selectors (e.g.SubgraphServiceInvalidPaymentType) are excluded from bisection and surfaced immediately.Backwards compatibility
All defaults preserve existing behaviour. Operators currently failing due to oversized batches recover automatically on upgrade with no config change required.