Support exactOptionalPropertyTypes flag#386
Open
VanCoding wants to merge 3 commits into
Open
Conversation
VanCoding
changed the title
Author
|
@aexol Any way to the this merged in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi and thanks a lot for this awesome library!
Today I wanted to switch on the TypeScript option "exactOptionalPropertyTypes" for a project and noticed that the generated Zeus client doesn't like it. So I decided to fix it by myself quickly and make a PR. And here it is now :)
What I wasn't sure about was the example-code. When I generate it, I get a different schema and a therefore a different client.
Let me know if I missed something or if there's anything else I should do before you can merge it.
Best regards and thanks again,
Patrik