Update e2e tests and right size prev fix attempts#8234
Merged
jonathanawesome merged 3 commits intoJul 18, 2026
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
jdolle
approved these changes
Jul 18, 2026
jonathanawesome
deleted the
update-e2e-tests-and-right-size-prev-fix-attempts
branch
July 18, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the intermittent flakiness in the usage e2e tests (
usage.spec.ts). The failures were a test-side race, not an ingestion problem: the Insights poll reloaded the page every ~2s and counted matching rows immediately after the app shell mounted, so under CI load it kept snapshotting the still-loading (skeleton) state and reloading the page away before its data rendered. The heavier per-client Insights page was the one that lost the race, which is why the failures were always on/insights/client/....Changes:
toBeVisible) before retrying, instead of snapshotting mid-load with.count().The
wait_for_async_insert=1e2e ingestor setting is intentionally kept: it makes reported operations queryable quickly and removes ingestion timing as a variable.