Skip to content

reproduction to showcase a bug in the composition library #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickbijkerk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reproduction to showcase a bug in the composition library #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions __tests__/composition.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,6 +2235,42 @@ testImplementations((api) => {
expect(result.publicSdl).not.toMatch(/lowercase/);
});

test("requires on field with arguments without providing said arguments should fail", () => {
let result = composeServices([
{
name: "a",
typeDefs: parse(/* GraphQL */ `
extend schema
@link(url: "https://specs.apollo.dev/federation/v2.3"
import: ["@key"]
)
type Query {
product(id:ID!): Product
}
type Product @key(fields: "id"){
id: ID!
description(filter: String!): String!
}
`),
},
{
name: "b",
typeDefs: parse(/* GraphQL */ `
extend schema
@link(url: "https://specs.apollo.dev/federation/v2.3"
import: ["@key", "@external", "@requires"]
)
type Product @key(fields: "id"){
id: ID!
description (filter: String!): String! @external
calculatedField: String! @requires(fields: "description")
}
`),
}
]);
assertCompositionFailure(result);
});
Comment on lines +2238 to +2272
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation in this test case is inconsistent with the rest of the file. Aligning it with the surrounding tests will improve code readability and maintainability. I've also changed let to const as result is not reassigned, which is a good practice.

    test("requires on field with arguments without providing said arguments should fail", () => {
      const result = composeServices([
        {
          name: "a",
          typeDefs: parse(/* GraphQL */ `
            extend schema
              @link(url: "https://specs.apollo.dev/federation/v2.3"
                import: ["@key"]
              )
            type Query {
              product(id:ID!): Product
            }
            type Product @key(fields: "id"){
              id: ID!
              description(filter: String!): String!
            }
          `),
        },
        {
          name: "b",
          typeDefs: parse(/* GraphQL */ `
            extend schema
              @link(url: "https://specs.apollo.dev/federation/v2.3"
                import: ["@key", "@external", "@requires"]
              )
            type Product @key(fields: "id"){
              id: ID!
              description (filter: String!): String! @external
              calculatedField: String! @requires(fields: "description")
            }
          `),
        }
      ]);
      assertCompositionFailure(result);
    });


test("preserve directive from one subgraph if defined differently across subgraphs but one included in @composeDirective", () => {
const result = composeServices([
{
Expand Down