fix: REQUIRED_INACCESSIBLE with default values#299
Merged
kamilkisiela merged 3 commits intomainfrom Apr 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds new test cases to REQUIRED_INACCESSIBLE.spec.ts to verify that the @inaccessible directive is permitted on required arguments and input fields when a default value is provided. The reviewer noted that these tests currently fail and will break the CI pipeline. To address this, it is recommended to either update the RequiredArgumentOrFieldIsNotInaccessibleRule validation logic to check for default values or mark the tests with test.todo() or test.fails() to keep the CI green.
n1ru4l
changed the title
Contributor
dotansimha
approved these changes
Apr 26, 2026
Member
dotansimha
left a comment
dotansimha
left a comment
There was a problem hiding this comment.
LGTM. But let's wait for @kamilkisiela 's review as well, as he might have broader context than me on this one :)
n1ru4l
pushed a commit
that referenced
this pull request
Apr 28, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/federation-composition@0.22.3 ### Patch Changes - [#299](#299) [`c417891`](c417891) Thanks [@n1ru4l](https://github.com/n1ru4l)! - Fix `REQUIRED_INACCESSIBLE` composition rule reporting a composition error if `@inaccessible` is applied on a non-nullable field with a default value. In the following example schema the `Query.ping(message:)` argument no longer raises `REQUIRED_INACCESSIBLE`, as a default value for the argument is provided. The same behaviour applies for input type fields. ```graphql extend schema @link( url: "https://specs.apollo.dev/federation/v2.9" import: ["@inaccessible"] ) type Query { ping(message: String! = "pong" @inaccessible): String! } ``` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
REQUIRED_INACCESSIBLEcomposition rule reporting a composition error if@inaccessibleis applied on a non-nullable field with a default value.In the following example schema the
Query.ping(message:)argument no longer raisesREQUIRED_INACCESSIBLE, as a default value for the argument is provided. The same behaviour applies for input type fields.