Commit 7123fd6
authored
v6: Give the tab close button hover and focus states (#4420)
## Summary
The tab close button (`.graphiql-tab-close`) only changed text color on
hover: no background, no rounded corners, no transition, and no
`:focus-visible` outline. It's a keyboard-focusable button, so tabbing
to it left no visible focus indicator at all. That's an accessibility
gap, and it was the one icon button in the app that didn't match the
hover/focus pattern used everywhere else: the activity rail, toolbar
buttons, and the dialog close button. It now follows that same pattern.
## Test plan
- [x] Open several editor tabs, keyboard-Tab to a tab's close (✕)
button, and confirm it shows a clear blue focus ring.
- [x] Hover the close button and confirm a subtle background appears
behind it with rounded corners.
- [x] Click the close button and confirm the tab still closes as before.
- [x] Check both Dark and Light themes. The hover background and focus
ring should be legible in each.
Refs: #42191 parent 5890bf3 commit 7123fd6
1 file changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
92 | 96 | | |
93 | 97 | | |
94 | 98 | | |
| |||
97 | 101 | | |
98 | 102 | | |
99 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
100 | 110 | | |
101 | 111 | | |
102 | 112 | | |
| |||
0 commit comments