Skip to content

Commit e4f5148

Browse files
Fix vsix download path in publish job (#4267)
## Summary The vsix publish jobs failed with `ENOENT` in the last release. `actions/upload-artifact@v4` strips the path prefix up to the first wildcard segment, so `packages/vscode-graphql*/*.vsix` only preserves `vscode-graphql*/<file>` in the artifact — but the publish script looks under `vsix/packages/<pkg>/`. Setting the download `path` to `vsix/packages` lines things back up. A patch changeset re-bumps the three VSCode extensions so the next release exercises the publish path. Failed run: https://github.com/graphql/graphiql/actions/runs/25878625719 ## Test plan Only exercisable by a real release. The previous run's `attach` step succeeded, so `0.13.4` / `1.3.10` / `0.3.4` can still be manually uploaded from the GitHub Release `.vsix` assets via `vsce publish` and `ovsx publish` if those versions are wanted on the marketplaces.
1 parent 1e608ea commit e4f5148

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'vscode-graphql-execution': patch
3+
'vscode-graphql-syntax': patch
4+
'vscode-graphql': patch
5+
---
6+
7+
Burning patch version due to previous release failure.

.github/workflows/release.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,12 @@ jobs:
108108
- uses: actions/download-artifact@v4
109109
with:
110110
name: vscode-extensions
111-
path: vsix
111+
# `upload-artifact` strips the path prefix up to the first wildcard
112+
# segment, so the artifact contains `vscode-graphql*/*.vsix` rather
113+
# than `packages/vscode-graphql*/*.vsix`. Restore the `packages/`
114+
# prefix here so the layout lines up with `vsixPath('vsix', …)` in
115+
# the script.
116+
path: vsix/packages
112117

113118
- name: Publish
114119
env:

0 commit comments

Comments
 (0)