v6: Add Lost Pixel for Storybook visual regression#4256
Closed
trevor-scheer wants to merge 1 commit into
Closed
Conversation
|
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
trevor-scheer
force-pushed
the
trevor/lost-pixel-vr
branch
from
May 13, 2026 14:48
ceebc4c to
d4bf0f5
Compare
Lost Pixel screenshots every Storybook story, compares against committed baselines, and fails CI on unintended pixel diffs. Lives in `@graphiql/react` since that's our only package with UI stories. Threshold is 0.1% rather than the more common 1% — components like the spinner are small enough that 1% misses obvious changes. Local: `yarn workspace @graphiql/react test:vr` to check, `test:vr:update` to refresh after intentional changes.
trevor-scheer
force-pushed
the
trevor/lost-pixel-vr
branch
from
May 13, 2026 14:57
d4bf0f5 to
11852f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A visual-regression gate for the v6 component restyles. Every Storybook story produces a PNG, baselines live in the repo, and CI fails on unintended pixel diffs.
lost-pixelas a dev dep in@graphiql/react..lostpixel/baseline/. One so far: the spinner..github/workflows/visual-regression.ymlruns the diff on each PR tographiql-6.Threshold is 0.1% — at 1% a full-component color swap on the spinner only shifted 0.33% of pixels, under threshold.
Committed PNG baselines will accumulate as the matrix grows; we'll decide before GA whether to keep this, swap to Chromatic, or drop it.
Run locally
Refs: #4219