v6: Make the font-size setting reach the doc explorer, headers, and pills#4422
Merged
Conversation
`--font-size-hint` in `root.css` was a frozen v5 value that never scaled with the font-size preset. All ~19 call sites (var-headers-strip, collections, history, doc-explorer) are caption/label text, so they now use `--font-size-eyebrow` and track Settings > Font size. The dead `--font-size-hint` definition is removed since nothing references it anymore.
…header, panel-header, method-pill `field-card`, `type-card`, `fields-list`, `response-header`, `panel-header`, and `method-pill` all hardcoded `font-size` in px, so they silently ignored the Settings font-size preset. Swapped each for the nearest `--font-size-*` token (verified against the resolved `--font-size-body` alias, which turned out to be shadowed by a frozen legacy value in `root.css` — used `--font-size-mono` instead for the mono-family names/types so they actually track the preset).
|
trevor-scheer
marked this pull request as ready for review
July 13, 2026 02:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
field-card,type-card, andfields-listall hardcodedfont-sizein px (11.5px, 14px, 10px, 9px, and more), so none of that text grew or shrank with the font-size preset. They now read--font-size-mono,--font-size-small, or--font-size-eyebrowdepending on which is closest to the original size.response-header,panel-header, andmethod-pillhad the same problem: fixed px values that ignored Settings > Font size entirely. Migrated to the matching tokens.--font-size-hinttoken (root.css) was a frozen value that never scaled with the preset, at ~19 call sites acrossvar-headers-strip, the collections plugin, the history plugin, and the doc-explorer plugin. Every usage now points at--font-size-eyebrowinstead, and the dead--font-size-hintdefinition is gone.--font-size-bodyitself is silently shadowed by a frozen legacy value inroot.css(same class of bug, but out of scope here, so flagged separately). Avoided that token in the new mappings and used--font-size-monofor the mono-family names/types instead, since it actually rescales.Test plan
Refs: #4228