v6: Unify list-row hover across the Doc Explorer and History panels#4424
Merged
Conversation
A single 120ms ease transition token, so hover transitions across the app can converge on one duration instead of three different ones.
Doc explorer rows hovered with an `--fg-default` alpha tint and history rows hovered with an `--accent-blue` alpha tint, while activity-rail, dropdown-menu, and collections all use a flat `oklch(var(--bg-subtle))` hover. Converge doc explorer (`fields-list`, `schema-documentation`, `search`, `search-row`) and history rows onto that same standard, and bring history's action-icon hover (previously its own fourth recipe, `--fg-default` at a different alpha) in line too. `--accent-blue` stays reserved for genuine active/selected state: the active field row in the doc explorer, and the editable/rename state in history. Neither of those is a hover, so they're untouched. Also apply `--transition-fast` to all of the above row hovers, since none of them transitioned before and this PR is already touching every one of them.
|
trevor-scheer
marked this pull request as ready for review
July 13, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List rows across the side panels had four different "this row is highlighted" recipes doing the same job. Activity rail, dropdown menu items, and Collections rows all used a flat
oklch(var(--bg-subtle))background on hover, which is the pattern the rest of the app's interactive chrome had already settled on. Doc explorer rows instead tinted with--fg-defaultat a few different alpha values, History rows tinted with--accent-blue, and History's own action icons (rename/favorite/delete) used yet a fourth recipe (--fg-defaultat a different alpha again), all in the same file as the third.Doc explorer (fields list, schema overview, and both search listboxes) and History now hover with the same flat
--bg-subtlebackground as Collections, and History's action icons match too.--accent-blueis reserved for genuine active/selected state: the active field row in doc explorer, and the editable/rename row in History, both of which are untouched.Separately, only three files in the whole app had a hover
transition, each with its own duration (120ms, 100ms, 120ms/150ms), while nearly everything else snapped instantly. Rather than pick a side, this PR adds a single--transition-fast: 120ms easetoken totokens.cssand applies it to every row hover touched here, so the newly-unified hover reads as one consistent, intentional motion instead of an arbitrary mix. The three pre-existing transition durations elsewhere are unchanged for now, out of scope for this pass.Test plan
Refs: #4228