v6: align font tokens with the Roboto/Fira Code that actually ship#4428
Merged
Conversation
tokens.css declared Inter/JetBrains Mono while root.css shadowed those same variables back to Roboto/Fira Code on .graphiql-container, and style.css only ever loaded the Roboto/Fira Code font files. Point the canonical token declaration at the fonts that actually ship, and drop the now-redundant container-level override.
|
trevor-scheer
marked this pull request as ready for review
July 15, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokens.cssdeclared--font-family: 'Inter'and--font-family-mono: 'JetBrains Mono', but nothing in the app ever rendered in either.root.cssredeclared both variables on.graphiql-container, pointing them back at Roboto and Fira Code, and that selector beats:rootin the cascade.packages/graphiql/src/style.cssonly ever@imports the Roboto and Fira Code@font-facefiles, so Inter and JetBrains Mono weren't loaded to begin with — even if the cascade had gone the other way, the browser would have fallen through to the generic fallbacks.We decided in #4426 to keep Roboto and Fira Code rather than swap the type system, so this points the canonical declaration in
tokens.cssat the fonts that actually ship and drops the now-redundant.graphiql-containeroverride. One declaration, and it matches what you see. No font loading changes.Test plan
font-familyresolves to Fira Code and Roboto respectively, same as before this change.--font-familyon.graphiql-containernow inherits from:rootrather than being overridden locally, and that its value is Roboto.Refs: #4219