Updates to schema coordinates (#3044)#4422
Merged
Merged
Conversation
magicmark
commented
May 31, 2025
martinbonnin
approved these changes
May 31, 2025
martinbonnin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into this ❤️
Contributor
|
Code looks good, mainly feeling conflicted about conflating enum-members and type-fields. Input-fields and type-fields feel similar compared to enum-members |
- Add error handling as proposed by Benjie
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Merged
martinbonnin
approved these changes
Jun 2, 2025
yaacovCR
approved these changes
Jun 4, 2025
Member
|
@JoviDeCroock has a good point, and perhaps it would actually be better to represent this in the schema coordinates syntax itself:
|
Member
|
I have raised magicmark/graphql-spec#1; if we agree then I'll also make these changes to this branch and get it merged into #3044 |
…ndling Error handling
Contributor
Author
|
ack. @benjie done! added the enum changes. |
benjie
approved these changes
Jun 5, 2025
Member
|
Merging this even though it doesn't pass CI under the instruction of the champion 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to #3044
Implements the new spec changes:
FieldCoordinate,ArgumentCoordinateetc)MyEnum::valueseparator syntax