Skip to content

polish(benchmark): handle theoretical stats errors #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 1 commit into from
Apr 23, 2026
Merged

polish(benchmark): handle theoretical stats errors #4687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions resources/benchmark/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,23 @@ function runBenchmark(

const results: Array<BenchmarkResult> = [];
for (let i = 0; i < benchmarkProjects.length; ++i) {
results.push(
computeStats(
let result: BenchmarkResult;
try {
result = computeStats(
benchmarkProjects[i].revision,
timingSamples[i],
memorySamples[i],
),
);
);
} catch (error) {
const errorMessage =
error instanceof Error ? error.message : String(error);
console.log(
' ' + benchmarkProjects[i].revision + ': ' + red(errorMessage),
);
return;
}

results.push(result);
}

console.log('\n');
Expand Down
3 changes: 0 additions & 3 deletions resources/benchmark/statistics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ export function computeStats(
timingSamples: ReadonlyArray<number>,
memorySamples: ReadonlyArray<number>,
): BenchmarkResult {
assert(timingSamples.length > 1);
assert(memorySamples.length > 0);

const { mean, marginOfError } = computeMeanStats(timingSamples);

let meanMemUsed = 0;
Expand Down
Loading