Skip to content

Commit b57790d

Browse files
authored
Fixes for incremenal delivery integration branch (#1232)
1 parent 0a475eb commit b57790d

2 files changed

Lines changed: 8 additions & 12 deletions

File tree

spec/Section 5 -- Validation.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ FieldsInSetCanMerge(set):
560560
{set} including visiting fragments and inline fragments.
561561
- Given each pair of distinct members {fieldA} and {fieldB} in {fieldsForName}:
562562
- {SameResponseShape(fieldA, fieldB)} must be true.
563-
- {SameStreamDirective(fieldA, fieldB)} must be true.
563+
- {HasNoOverlappingStreams(fieldA, fieldB)} must be true.
564564
- If the parent types of {fieldA} and {fieldB} are equal or if either is not
565565
an Object Type:
566566
- {fieldA} and {fieldB} must have identical field names.
@@ -596,14 +596,10 @@ SameResponseShape(fieldA, fieldB):
596596
- If {SameResponseShape(subfieldA, subfieldB)} is {false}, return {false}.
597597
- Return {true}.
598598

599-
SameStreamDirective(fieldA, fieldB):
599+
HasNoOverlappingStreams(fieldA, fieldB):
600600

601601
- If neither {fieldA} nor {fieldB} has a directive named `stream`.
602602
- Return {true}.
603-
- If both {fieldA} and {fieldB} have a directive named `stream`.
604-
- Let {streamA} be the directive named `stream` on {fieldA}.
605-
- Let {streamB} be the directive named `stream` on {fieldB}.
606-
- If {streamA} and {streamB} have identical sets of arguments, return {true}.
607603
- Return {false}.
608604

609605
Note: In prior versions of the spec the term "composite" was used to signal a

spec/Section 7 -- Response.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -433,10 +433,10 @@ An _incremental pending notice_ must contain entries with the keys {"id"} and
433433
{"path"}, and may contain an entry with key {"label"}.
434434

435435
The value of {"id"} must be a string. This {"id"} should be used by clients to
436-
correlate incremental pending notices with _incremental result_ and _completed
437-
result_. The {"id"} value must be unique across the entire _incremental stream_
438-
response. There must not be any other incremental pending notice in the
439-
_incremental stream_ with the same {"id"}.
436+
correlate incremental pending notices with _incremental result_ and _incremental
437+
completion notice_. The {"id"} value must be unique across the entire
438+
_incremental stream_ response. There must not be any other incremental pending
439+
notice in the _incremental stream_ with the same {"id"}.
440440

441441
The value of {"path"} must be a _response position_. When the incremental
442442
pending notice is associated with a `@stream` directive, it indicates the list
@@ -574,8 +574,8 @@ and may contain an entry with the key {"errors"}.
574574
The value of {"id"} must be a string referencing its _associated incremental
575575
pending notice_. The associated incremental pending notice must appear either in
576576
the _initial incremental stream result_, in a prior _incremental stream update
577-
result_, or in the same _incremental stream update result_ as the _completed
578-
result_ that references it.
577+
result_, or in the same _incremental stream update result_ as the _incremental
578+
completion notice_ that references it.
579579

580580
The value of {"errors"}, if present, informs clients that the delivery of the
581581
data from the _associated incremental pending notice_ has failed, due to an

0 commit comments

Comments
 (0)