Improve error handling

Author: hasparus

src/app/conf/2023/speakers/[id]/page.tsx

@@ -47,9 +47,15 @@ export default function SpeakerPage({ params }: SpeakerProps) {
     .filter(s => s.speakers && s.speakers.some(s => s.username === params.id))
     .map(s => ({
       ...s,
-      speakers: s.speakers!.map(
-        s => speakers.find(speaker => speaker.username === s.username)!,
-      ),
+      speakers: s.speakers!.map(other => {
+        const s = speakers.find(s => s.username === other.username)
+        if (!s) {
+          throw new Error(
+            `Speaker "${other.username}" not found for ${speaker.username} details page`,
+          )
+        }
+        return s
+      }),
     }))
 
   return (

src/app/conf/2024/schedule/[id]/page.tsx

@@ -34,7 +34,11 @@ function getEventTitle(event: ScheduleSession, speakers: string[]): string {
 type SessionProps = { params: { id: string } }
 
 export function generateMetadata({ params }: SessionProps): Metadata {
-  const event = schedule.find(s => s.id === params.id)!
+  const event = schedule.find(s => s.id === params.id)
+
+  if (!event) {
+    notFound()
+  }
 
   const keywords = [
     event.event_type,
@@ -77,14 +81,20 @@ const Tag = ({
 
 export default function SessionPage({ params }: SessionProps) {
   const event = schedule.find(s => s.id === params.id)
+
   if (!event) {
     notFound()
   }
 
-  // @ts-expect-error -- fixme
-  event.speakers = (event.speakers || []).map(speaker =>
-    speakers.find(s => s.username === speaker.username),
-  )
+  event.speakers = (event.speakers || []).map(speaker => {
+    const s = speakers.find(s => s.username === speaker.username)
+    if (!s) {
+      throw new Error(
+        `Speaker "${speaker.username}" not found for "${event.name}"`,
+      )
+    }
+    return s
+  })
 
   const eventType = event.event_type.endsWith("s")
     ? event.event_type.slice(0, -1)

src/app/conf/2024/speakers/[id]/page.tsx

@@ -40,17 +40,27 @@ export function generateStaticParams() {
 
 export default function SpeakerPage({ params }: SpeakerProps) {
   const decodedId = decodeURIComponent(params.id)
-  const speaker = speakers.find(s => s.username === decodedId)!
+  const speaker = speakers.find(s => s.username === decodedId)
+
+  if (!speaker) {
+    throw new Error(`Speaker "${decodedId}" not found for details page`)
+  }
 
   const s = schedule
     .filter((s): s is typeof s & Required<Pick<typeof s, "speakers">> =>
       Boolean(s.speakers && s.speakers.some(s => s.username === decodedId)),
     )
     .map(s => ({
       ...s,
-      speakers: s.speakers.map(
-        s => speakers.find(speaker => speaker.username === s.username)!,
-      ),
+      speakers: s.speakers.map(other => {
+        const s = speakers.find(s => other.username === s.username)
+        if (!s) {
+          throw new Error(
+            `Speaker "${other.username}" not found for ${speaker.username} details page`,
+          )
+        }
+        return s
+      }),
     }))
 
   return (