refactor: enforce Core Mission compliance across all domains#31
Merged
Conversation
Replace raw turn_on/turn_off with intent-specific methods: - Light: on(), off(), set_brightness(), set_kelvin(), set_rgb(), set_color() - Switch: on(), off(), toggle() - Climate: remove turn_on/turn_off, use set_hvac_mode() - MediaPlayer: power_on(), power_off() - BinarySensor: on_activate/on_deactivate listeners Make call_service private (_call_service) at Entity, HAClient, and SyncHAClient layers. Remove unused UnsupportedOperationError. Add SyncHAClient.scene() and timer() accessors. Re-export Timer from package. Add NumPy-style docstrings to all public APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn_on/turn_offwith intent-specific methods across all domains (Light, Switch, Climate, MediaPlayer, BinarySensor)call_serviceprivate (_call_service) at Entity, HAClient, and SyncHAClient layersUnsupportedOperationError; add missingTimerexport andSyncHAClient.scene()/timer()accessorsDomain Changes
turn_on(brightness=50)set_brightness(50),on(),off(),set_kelvin(),set_rgb(),set_color()turn_on()/turn_off()on()/off()/toggle()turn_on()/turn_off()set_hvac_mode()onlyturn_on()/turn_off()power_on()/power_off()on_turn_on/on_turn_offon_activate/on_deactivateQuality