feat: reimplement Scene domain with create, apply, and delete support#43
Merged
Conversation
Add delete() to Scene for removing dynamically-created scenes. Add create_scene() and apply_scene() to HAClient and SyncHAClient. Add Scene to mkdocs documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete()method toScenefor removing dynamically-created scenes viascene.deleteservicecreate_scene()toHAClientfor creating dynamic scenes viascene.createservice, returning aSceneinstanceapply_scene()toHAClientfor applying entity states without persisting viascene.applyservicecreate_scene,apply_scene) toSyncHAClientChanges
src/haclient/domains/scene.pydelete()methodsrc/haclient/client.pycreate_scene()andapply_scene()src/haclient/sync.pytests/test_client.pytests/test_domains.pytests/test_sync.pydocs/reference/domains/scene.mdmkdocs.ymlAll checks pass: lint, mypy, 188 tests, 95.34% coverage.