Skip to content

Commit 9671c6d

Browse files
committed
test: migrate remaining junit 4 assertion leftovers to junit 5
- gateway-core HttpEndpointInvokerTest: junit.framework.AssertionFailedError -> org.opentest4j.AssertionFailedError - repository-test SubscriptionRepositoryTest: assertEquals message argument moved to the junit 5 last-arg position
1 parent f78e861 commit 9671c6d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

gravitee-apim-gateway/gravitee-apim-gateway-core/src/test/java/io/gravitee/gateway/reactive/core/v4/invoker/HttpEndpointInvokerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import io.reactivex.rxjava3.observers.TestObserver;
4242
import java.util.List;
4343
import java.util.stream.Stream;
44-
import junit.framework.AssertionFailedError;
4544
import org.assertj.core.api.Assertions;
4645
import org.assertj.core.api.InstanceOfAssertFactory;
4746
import org.junit.jupiter.api.BeforeEach;
@@ -53,6 +52,7 @@
5352
import org.junit.jupiter.params.provider.ValueSource;
5453
import org.mockito.Mock;
5554
import org.mockito.junit.jupiter.MockitoExtension;
55+
import org.opentest4j.AssertionFailedError;
5656

5757
/**
5858
* @author Jeoffrey HAEYAERT (jeoffrey.haeyaert at graviteesource.com)

gravitee-apim-repository/gravitee-apim-repository-test/src/test/java/io/gravitee/repository/management/SubscriptionRepositoryTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -831,11 +831,11 @@ public void searchAfter_shouldPaginateByIdOnlyFallback() throws TechnicalExcepti
831831

832832
// Keyset pagination must reproduce the single-page order exactly — same elements, same order,
833833
// no skips or duplicates. This holds only when the seek predicate agrees with the sort.
834-
assertEquals("id-only keyset pagination must reproduce the single-page id order (no skip/dup/reorder)", singlePageOrder, paged);
834+
assertEquals(singlePageOrder, paged, "id-only keyset pagination must reproduce the single-page id order (no skip/dup/reorder)");
835835
assertEquals(
836-
"plan3 subs returned exactly — no leak from unrelated plans",
837836
Set.of("sub-legacy-push", "sub2", "sub3", "sub6", "sub7", "sub8"),
838-
new java.util.HashSet<>(paged)
837+
new java.util.HashSet<>(paged),
838+
"plan3 subs returned exactly — no leak from unrelated plans"
839839
);
840840
}
841841

0 commit comments

Comments
 (0)