Skip to content

NM-294: SIEM Integration (just moved flow grpc client to netmaker)#1313

Open
VishalDalwadi wants to merge 1 commit into
developfrom
NM-294
Open

NM-294: SIEM Integration (just moved flow grpc client to netmaker)#1313
VishalDalwadi wants to merge 1 commit into
developfrom
NM-294

Conversation

@VishalDalwadi
Copy link
Copy Markdown
Contributor

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@tenki-reviewer
Copy link
Copy Markdown
Contributor

tenki-reviewer Bot commented May 21, 2026

Review Complete
No issues found!

Risk: 🟢 Low (5/100) — no findings · 255 LOC across 3 files


This PR cleanly relocates the gRPC flow client from the local flow/exporter package into the upstream netmaker module, with the corresponding go.mod update. The refactoring is straightforward and introduces no new bugs or security issues.

Files Reviewed (3 files)
flow/exporter/grpc.go
flow/manager_linux.go
go.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant