Skip to content

fix(i18n): align Russian translation inconsistencies (step 1)#1098

Draft
makhnatkin wants to merge 3 commits intomainfrom
fix/i18n-step1
Draft

fix(i18n): align Russian translation inconsistencies (step 1)#1098
makhnatkin wants to merge 3 commits intomainfrom
fix/i18n-step1

Conversation

@makhnatkin
Copy link
Copy Markdown
Collaborator

@makhnatkin makhnatkin commented Apr 22, 2026 •
edited by sourcery-ai Bot
Loading

Summary

Fixes translation inconsistencies identified in #1097 (Step 1).

  • common_action_cancel / confirm-cancel: changed "Отменить" (verb) → "Отмена" (noun) for consistency across the editor
  • cell.preview in yfm-layout: changed "Превью" → "Предпросмотр" (matches common/ru.json, bundle/ru.json)
  • try-again in gpt/dialog: changed "Иначе" (Otherwise) → "Повторить" — the button uses ArrowRotateLeft icon and triggers handleTryAgain (retry same request), so "Повторить" matches both the intent and the retry-button convention in gpt/errors/ru.json

Note on refetch: This key exists in gpt/dialog/ru.json but is not referenced anywhere in the source code — left as-is for now (dead key cleanup can be a separate PR).

Test plan

  • Verify no TypeScript errors introduced (pnpm build)
  • Verify unit tests pass (pnpm test)
  • Visually check cancel buttons in forms and GPT dialog show "Отмена"
  • Visually check yfm-layout cell preview label shows "Предпросмотр"
  • Visually check GPT dialog "try again" button shows "Повторить"

🤖 Generated with Claude Code

Summary by Sourcery

Bug Fixes:

  • Correct inconsistent Russian translations for cancel actions, preview labels, and GPT retry button text across editor modules.

@makhnatkin @claude
fix(i18n): align Russian translation inconsistencies (step 1)
903bce2 
- common_action_cancel, confirm-cancel: "Отменить" → "Отмена" (noun form)
- cell.preview: "Превью" → "Предпросмотр" (consistent with rest of project)
- try-again: "Иначе" → "Повторить" (matches retry button intent and gpt/errors convention)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@makhnatkin makhnatkin requested a review from d3m1d0v as a code owner April 22, 2026 15:38
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 22, 2026 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates several Russian i18n JSON files to standardize key translations across the editor, aligning button labels and preview terminology with existing conventions and actual UI behavior.

File-Level Changes

Change Details Files
Standardize Russian translation for cancel actions to use the noun form for consistency across the editor.
  • Update the value of the cancel-related translation key to use "Отмена" instead of the verb form "Отменить".
  • Ensure cancel buttons across forms and GPT dialog rely on the updated shared translation for a consistent label.
 packages/editor/src/i18n/forms/ru.json
packages/editor/src/i18n/gpt/dialog/ru.json
Align GPT dialog retry button translation with its behavior and existing retry conventions.
  • Change the translation of the try-again button from "Иначе" to "Повторить" to reflect a retry action.
  • Keep the unused "refetch" key unchanged, noting it as a candidate for cleanup in a future PR.
 packages/editor/src/i18n/gpt/dialog/ru.json
packages/editor/src/i18n/gpt/extension/ru.json
Unify terminology for preview labels in YFM layout with other bundles.
  • Update the translation for the cell preview label from "Превью" to "Предпросмотр" to match existing common and bundle Russian JSON translations.
 packages/editor/src/i18n/yfm-layout/ru.json
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@makhnatkin makhnatkin marked this pull request as draft April 22, 2026 15:40
@gravity-ui
Copy link
Copy Markdown

gravity-ui Bot commented Apr 22, 2026

Storybook Deployed

@gravity-ui
Copy link
Copy Markdown

gravity-ui Bot commented Apr 22, 2026 •
edited
Loading

🎭 Playwright Report

sourcery-ai[bot]
sourcery-ai Bot reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@d3m1d0v d3m1d0v Awaiting requested review from d3m1d0v d3m1d0v is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@makhnatkin