feat(Popup, Select)!: set default common floating offset#2660
Open
Valent1325 wants to merge 2 commits into
Open
feat(Popup, Select)!: set default common floating offset#2660Valent1325 wants to merge 2 commits into
Valent1325 wants to merge 2 commits into
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideIntroduce a shared FLOATING_OFFSET constant and use it as the default offset for Popup and as the main-axis offset in SelectPopup floating middlewares to keep popup spacing consistent across components. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Preview is ready. |
korvin89
reviewed
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Something went wrong here.
Contributor
Author
There was a problem hiding this comment.
I returned correct snapshot
korvin89
requested changes
Apr 29, 2026
Contributor
korvin89
left a comment
There was a problem hiding this comment.
This is a breaking change, let's fix the screenshot and wait for V8
Contributor
|
🎭 Component Tests Report is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Set a shared floating offset constant and use it as the default spacing for popup and select popups.
New Features:
Enhancements: