Skip to content

fix: use variables for button and label components#2694

Merged
amje merged 1 commit into
mainfrom
fix/use-variables-height
Jul 13, 2026
Merged

fix: use variables for button and label components#2694
amje merged 1 commit into
mainfrom
fix/use-variables-height

Conversation

@qradle-yndx

@qradle-yndx qradle-yndx commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Use shared SCSS variables for component heights across button and label size variants.

Enhancements:

  • Replace hardcoded height values in button and label size modifiers with shared SCSS height variables to centralize sizing tokens.
  • Introduce a new $xxs-height variable for the smallest label size to align it with the shared sizing system.

@sourcery-ai

sourcery-ai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR replaces hardcoded pixel heights in Button and Label size modifiers with shared SCSS variables defined in variables.scss, aligning component sizing with the design token system.

File-Level Changes

Change Details Files
Use shared height tokens for Button size variants instead of hardcoded pixel values.
  • Replaced hardcoded --_--height values for xs, s, m, l, xl Button size modifiers with interpolated SCSS variables
  • Kept existing border-radius, padding, and icon-space CSS custom properties unchanged for each size
src/components/Button/Button.scss
Use shared height tokens for Label size variants instead of hardcoded pixel values.
  • Replaced hardcoded --_--height values for xxs, xs, s, m Label size modifiers with interpolated SCSS variables
  • Retained existing border-radius and margin-related CSS custom properties for each Label size
src/components/Label/Label.scss
Define shared height SCSS variables for use by Button and Label components.
  • Added $xxs-height variable for 18px height to support Label xxs size
  • Ensured existing size variables ($xs-height, $s-height, $m-height, etc.) are available for component usage
src/components/variables.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gravity-ui

gravity-ui Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Preview is ready.

@gravity-ui

gravity-ui Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🎭 Component Tests Report is ready.

@amje
amje merged commit 7e7aee8 into main Jul 13, 2026
6 of 7 checks passed
@amje
amje deleted the fix/use-variables-height branch July 13, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants