Skip to content

docs(Accordion): correct value types#2706

Open
SSDWGG wants to merge 1 commit into
gravity-ui:mainfrom
SSDWGG:docs/issue-2411-accordion-value-type
Open

docs(Accordion): correct value types#2706
SSDWGG wants to merge 1 commit into
gravity-ui:mainfrom
SSDWGG:docs/issue-2411-accordion-value-type

Conversation

@SSDWGG

@SSDWGG SSDWGG commented Jun 13, 2026

Copy link
Copy Markdown

Summary

  • document null as the empty Accordion value
  • update both English and Russian API tables

Fixes #2411

Summary by Sourcery

Documentation:

  • Update Accordion API docs to document null as the empty value for defaultValue and value in both English and Russian tables.

@SSDWGG SSDWGG requested a review from KostyaAvtushko as a code owner June 13, 2026 08:51
@sourcery-ai

sourcery-ai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Accordion component documentation in both English and Russian to correctly describe null as the empty value type for controlled (value) and uncontrolled (defaultValue) states instead of undefined.

File-Level Changes

Change Details Files
Correct documented value types for Accordion controlled and uncontrolled values.
  • Update English README API table to list `string
string[]

Assessment against linked issues

Issue Objective Addressed Explanation
#2411 Update the Accordion English documentation so that the value and defaultValue props are documented as having type `string string[] nullinstead ofstring
#2411 Update the Accordion Russian documentation so that the value and defaultValue props are documented as having type `string string[] nullinstead ofstring

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct the accordion value type in docs

1 participant