Skip to content

feat(dgeni): add deprecated field to API doc#3543

Merged
griest024 merged 2 commits into
graycoreio:developfrom
griest024:feat/dgeni/deprecated-flag
Apr 24, 2025
Merged

feat(dgeni): add deprecated field to API doc#3543
griest024 merged 2 commits into
graycoreio:developfrom
griest024:feat/dgeni/deprecated-flag

Conversation

@griest024

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3499

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added status: wip This PR is WIP. It should be marked as a draft. package: docs-utils @daffodil/docs-utils tools: dgeni @daffodil/tools-dgeni labels Mar 5, 2025
@griest024 griest024 requested a review from xelaint March 5, 2025 21:20
@griest024

Copy link
Copy Markdown
Member Author

@xelaint I've added the deprecated field to API docs, its ready for UI updates.

@xelaint

xelaint commented Mar 6, 2025

Copy link
Copy Markdown
Member

@griest024 I'm not seeing the deprecated tag on any of the deprecated classes?

@griest024

Copy link
Copy Markdown
Member Author

@griest024 I'm not seeing the deprecated tag on any of the deprecated classes?

It should be on the JSON document. I wasn't sure how to wire it up to the UI

@xelaint

xelaint commented Mar 7, 2025

Copy link
Copy Markdown
Member

@griest024 Something like this. I think I might need to create a docs specific article component to render the UI I want in docs.

Screen Shot 2025-03-07 at 12 53 10 PM Screen Shot 2025-03-07 at 12 54 01 PM

@griest024 griest024 added status: blocked This PR or issue is blocked and cannot currently be progressed and removed status: wip This PR is WIP. It should be marked as a draft. labels Mar 10, 2025
@griest024

Copy link
Copy Markdown
Member Author

blocked by #3554

@xelaint

xelaint commented Apr 18, 2025

Copy link
Copy Markdown
Member

Assuming we need #3550 merged before doing this? No longer blocked by #3554

@griest024 griest024 force-pushed the feat/dgeni/deprecated-flag branch from 6ea9419 to 2ed117b Compare April 22, 2025 22:26
@griest024

Copy link
Copy Markdown
Member Author

@xelaint ready for you to add UI. The deprecated field is on all API docs and props and methods. The value of this field is a message. Presence of the field indicates that the symbol is deprecated

@xelaint xelaint marked this pull request as ready for review April 23, 2025 22:13
@xelaint xelaint requested review from a team as code owners April 23, 2025 22:13
@griest024 griest024 added status: pending merge This PR has met all the requirements for merge and is waiting on an admin and removed status: blocked This PR or issue is blocked and cannot currently be progressed labels Apr 24, 2025
@griest024 griest024 merged commit 00ed925 into graycoreio:develop Apr 24, 2025
@gray-bot gray-bot mentioned this pull request Apr 24, 2025
@griest024 griest024 deleted the feat/dgeni/deprecated-flag branch April 24, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: docs-utils @daffodil/docs-utils status: pending merge This PR has met all the requirements for merge and is waiting on an admin tools: dgeni @daffodil/tools-dgeni

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Add deprecation indicator to deprecated API tokens

2 participants