chore(design): add docs-private-hostbinding-lifecycle linting rule#3639
Merged
damienwebdev merged 3 commits intoMay 8, 2025
Merged
Conversation
xelaint
requested changes
Apr 24, 2025
0afee00 to
9dbb0e1
Compare
Member
|
@damienwebdev does this need to apply to all packages, or just |
Member
|
Just design for now. |
9dbb0e1 to
89216e2
Compare
docs-private-hostbinding-lifecycle linting rule
89216e2 to
9dbb0e1
Compare
324cb4d to
91e4aca
Compare
Member
|
@damienwebdev should be good to go, only thing is codeclimate failing. |
91e4aca to
fb60255
Compare
Member
|
@xelaint needs a rebase. |
c2369e1 to
eb0f909
Compare
Member
@damienwebdev done |
xelaint
approved these changes
May 8, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No existing linting rule for @docs-private tag for HostBinding and Lifecycle methods.
Fixes: #3487
What is the new behavior?
Added linting rule, and added @docs-private tag to hostbinding and lifecycle methods.
Does this PR introduce a breaking change?
Notes: