Skip to content

feat(design)!: convert @daffodil/design/image to use signals#4597

Merged
xelaint merged 1 commit into
developfrom
feat/image-signal
Jul 17, 2026
Merged

feat(design)!: convert @daffodil/design/image to use signals#4597
xelaint merged 1 commit into
developfrom
feat/image-signal

Conversation

@xelaint

@xelaint xelaint commented Jul 17, 2026

Copy link
Copy Markdown
Member

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Part of: #4327

New behavior

Breaking change?

  • Yes
  • No

BREAKING CHANGE: @daffodil/design/image now exposes the DaffImageComponent inputs src, alt, width, and height as signals rather than plain properties, and renames the load output to loaded.

  • Input template bindings ([src], [alt], etc.) continue to work unchanged.
  • Programmatic reads must invoke the signal: image.srcimage.src(), image.widthimage.width(), etc.
  • Inputs are now read-only and can no longer be assigned imperatively (image.src = '/image/test.jpg' is no longer supported).

Additional context

@xelaint
xelaint requested review from a team as code owners July 17, 2026 13:09
@xelaint xelaint added package: design @daffodil/design 🚨 breaking changes This PR or issue will cause a breaking change labels Jul 17, 2026
@xelaint
xelaint merged commit 8ae04ce into develop Jul 17, 2026
16 checks passed
@gray-bot gray-bot mentioned this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant