Skip to content

Commit 83f9433

Browse files
committed
feat: remove rabbitmq from supported-version for mage-os/minimal
1 parent a7d48f5 commit 83f9433

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

supported-version/dist/index.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

supported-version/src/services/build-services.spec.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import { buildServicesForEntry } from './build-services';
22
import { PackageMatrixVersion } from '../matrix/matrix-type';
3+
import mageOsMinimalIndividual from '../versions/mage-os-minimal/individual.json';
4+
import mageOsMinimalComposite from '../versions/mage-os-minimal/composite.json';
35

46
const createTestEntry = (overrides: Partial<PackageMatrixVersion> = {}): PackageMatrixVersion => ({
57
magento: 'magento/project-community-edition:2.4.7',
@@ -362,4 +364,17 @@ describe('buildServicesForEntry', () => {
362364
expect(withPref).toEqual(withoutPref);
363365
});
364366
});
367+
368+
describe('mage-os-minimal', () => {
369+
const minimalEntries: [string, PackageMatrixVersion][] = [
370+
...Object.entries(mageOsMinimalIndividual as unknown as Record<string, PackageMatrixVersion>),
371+
...Object.entries(mageOsMinimalComposite as unknown as Record<string, PackageMatrixVersion>)
372+
];
373+
374+
it.each(minimalEntries)('omits rabbitmq from services for %s', (_key, entry) => {
375+
const services = buildServicesForEntry(entry);
376+
377+
expect(services.rabbitmq).toBeUndefined();
378+
});
379+
});
365380
});

supported-version/src/versions/mage-os-minimal/composite.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"composer": "2.9.8",
66
"mysql": "mysql:8.4",
77
"opensearch": "opensearchproject/opensearch:3",
8-
"rabbitmq": "rabbitmq:4.2-management",
98
"valkey": "valkey/valkey:9",
109
"varnish": "varnish:8",
1110
"nginx": "nginx:1.28",
@@ -19,7 +18,6 @@
1918
"composer": "2.9.8",
2019
"mysql": "mysql:8.4",
2120
"opensearch": "opensearchproject/opensearch:3",
22-
"rabbitmq": "rabbitmq:4.2-management",
2321
"valkey": "valkey/valkey:9",
2422
"varnish": "varnish:8",
2523
"nginx": "nginx:1.28",
@@ -33,7 +31,6 @@
3331
"composer": "2.9.8",
3432
"mysql": "mysql:8.4",
3533
"opensearch": "opensearchproject/opensearch:3",
36-
"rabbitmq": "rabbitmq:4.2-management",
3734
"valkey": "valkey/valkey:9",
3835
"varnish": "varnish:8",
3936
"nginx": "nginx:1.28",

supported-version/src/versions/mage-os-minimal/individual.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"composer": "2.9.8",
77
"mysql": "mysql:8.4",
88
"opensearch": "opensearchproject/opensearch:3",
9-
"rabbitmq": "rabbitmq:4.2-management",
109
"valkey": "valkey/valkey:9",
1110
"varnish": "varnish:8",
1211
"nginx": "nginx:1.28",

0 commit comments

Comments
 (0)