Skip to content

Commit e452bc7

Browse files
committed
feat!: use non-privileged ports for nginx
BREAKING CHANGE: Unfortunately, on Macs and Linux boxes, VSCode will often fail to port-forward 443 and 80. Sometimes, these will work and cause VSCode to request privileges, but more often than not, they don't. It's easier to just use a non-privileged port than fight against admin access. As such, you can now access your site on the portforward `8000`` and `8443` instead.
1 parent 087f82e commit e452bc7

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

compose/2.4.6/docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ services:
2424
- MAGENTO_TLS_CERT=snakeoil.crt
2525
- MAGENTO_TLS_KEY=snakeoil.key
2626
ports:
27-
- "80:8000"
28-
- "443:8443"
27+
- "8000:8000"
28+
- "8443:8443"
2929
networks:
3030
- magento
3131
depends_on:

compose/2.4.7/docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ services:
2424
- MAGENTO_TLS_CERT=snakeoil.crt
2525
- MAGENTO_TLS_KEY=snakeoil.key
2626
ports:
27-
- "80:8000"
28-
- "443:8443"
27+
- "8000:8000"
28+
- "8443:8443"
2929
networks:
3030
- magento
3131
depends_on:

compose/2.4.8/docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ services:
2424
- MAGENTO_TLS_CERT=snakeoil.crt
2525
- MAGENTO_TLS_KEY=snakeoil.key
2626
ports:
27-
- "80:8000"
28-
- "443:8443"
27+
- "8000:8000"
28+
- "8443:8443"
2929
networks:
3030
- magento
3131
depends_on:

compose/2.4.9/docker-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ services:
2424
- MAGENTO_TLS_CERT=snakeoil.crt
2525
- MAGENTO_TLS_KEY=snakeoil.key
2626
ports:
27-
- "80:8000"
28-
- "443:8443"
27+
- "8000:8000"
28+
- "8443:8443"
2929
networks:
3030
- magento
3131
depends_on:

devcontainer.json.sample

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@
99
"workspaceFolder": "/workspace",
1010
"service": "php",
1111
"forwardPorts": [
12-
80,
12+
"nginx:8000",
1313
3306,
1414
9200,
1515
5672,
1616
6379
1717
],
1818
"initializeCommand": "[ -f .devcontainer/magento2-devcontainer/.gitignore ] || (git submodule update --init --recursive)",
1919
"portsAttributes": {
20-
"80": {
20+
"8000": {
2121
"label": "Nginx"
2222
},
2323
"3306": {

0 commit comments

Comments
 (0)