Skip to content

Commit 74fccc7

Browse files
committed
Fix validation for default route
Signed-off-by: Taylor Gray <tylgry@amazon.com>
1 parent b422250 commit 74fccc7

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

data-prepper-core/src/integrationTest/resources/org/opensearch/dataprepper/pipeline/route/three-route-with-default-route.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ routing-pipeline:
1313
- alpha: '/value == "a"'
1414
- beta: '/value == "b"'
1515
- gamma: '/value == "g"'
16-
- _default: '/_default == "z"'
1716
sink:
1817
- in_memory:
1918
testing_key: ConditionalRoutingIT_alpha

data-prepper-pipeline-parser/src/main/java/org/opensearch/dataprepper/pipeline/parser/PipelineConfigurationValidator.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ public class PipelineConfigurationValidator {
3030
private static final String PIPELINE_TYPE = "pipeline";
3131
private static final Set<String> INVALID_PIPELINE_NAMES = new HashSet<>(List.of("data-prepper", "dataPrepper", "core"));
3232

33+
private static final String DEFAULT_ROUTE = "_default";
34+
3335
/**
3436
* Sorts the pipelines in topological order while also validating for
3537
* i. cycles in pipeline configuration
@@ -199,6 +201,7 @@ private static void validateSinkRoutes(final Map<String, PipelineConfiguration>
199201
}
200202
List<String> invalidRoutes = sinkRoutes.stream()
201203
.filter(route -> !validRoutes.contains(route))
204+
.filter(route -> !route.equals(DEFAULT_ROUTE))
202205
.collect(Collectors.toList());
203206

204207
if (!invalidRoutes.isEmpty()) {

0 commit comments

Comments
 (0)