Merge pull request #1667 from martinling/strict-prototypes

Firmware: Enable `-Wstrict-prototypes` and fix remaining warnings

Author: mossmann

firmware/common/fault_handler.c

@@ -73,17 +73,17 @@ __attribute__((used)) void hard_fault_handler_c(uint32_t* args)
 	while (1) {}
 }
 
-void mem_manage_handler()
+void mem_manage_handler(void)
 {
 	while (1) {}
 }
 
-void bus_fault_handler()
+void bus_fault_handler(void)
 {
 	while (1) {}
 }
 
-void usage_fault_handler()
+void usage_fault_handler(void)
 {
 	while (1) {}
 }

firmware/common/fpga.h

@@ -76,8 +76,8 @@ void fpga_set_tx_nco_enable(fpga_driver_t* const drv, const bool enable);
 void fpga_set_tx_nco_pstep(fpga_driver_t* const drv, const uint8_t phase_increment);
 
 bool fpga_image_load(unsigned int index);
-bool fpga_spi_selftest();
-bool fpga_sgpio_selftest();
-bool fpga_if_xcvr_selftest();
+bool fpga_spi_selftest(void);
+bool fpga_sgpio_selftest(void);
+bool fpga_if_xcvr_selftest(void);
 
 #endif // __FPGA_H

firmware/common/fpga_selftest.c

@@ -50,7 +50,7 @@ static int rx_samples(const unsigned int num_samples, uint32_t max_cycles)
 	return rc;
 }
 
-bool fpga_spi_selftest()
+bool fpga_spi_selftest(void)
 {
 	// Skip if FPGA configuration failed.
 	if (selftest.fpga_image_load != PASSED) {
@@ -81,7 +81,7 @@ static uint8_t lfsr_advance(uint8_t v)
 	return (v << 1) | feedback;
 }
 
-bool fpga_sgpio_selftest()
+bool fpga_sgpio_selftest(void)
 {
 	bool timeout = false;
 
@@ -168,7 +168,7 @@ static bool in_range(int value, int expected, int error)
 	return (value > min) && (value < max);
 }
 
-bool fpga_if_xcvr_selftest()
+bool fpga_if_xcvr_selftest(void)
 {
 	bool timeout = false;
 

firmware/common/gpdma.c

@@ -24,7 +24,7 @@
 
 #include <libopencm3/lpc43xx/gpdma.h>
 
-void gpdma_controller_enable()
+void gpdma_controller_enable(void)
 {
 	GPDMA_CONFIG |= GPDMA_CONFIG_E(1);
 	while ((GPDMA_CONFIG & GPDMA_CONFIG_E_MASK) == 0) {}

firmware/common/gpdma.h

@@ -28,7 +28,7 @@
 
 #include <libopencm3/lpc43xx/gpdma.h>
 
-void gpdma_controller_enable();
+void gpdma_controller_enable(void);
 
 void gpdma_channel_enable(const uint_fast8_t channel);
 void gpdma_channel_disable(const uint_fast8_t channel);

firmware/common/gpio.h

@@ -27,7 +27,7 @@
 
 typedef const struct gpio_t* gpio_t;
 
-void gpio_init();
+void gpio_init(void);
 void gpio_set(gpio_t gpio);
 void gpio_clear(gpio_t gpio);
 void gpio_toggle(gpio_t gpio);

firmware/common/gpio_lpc.c

@@ -24,7 +24,7 @@
 
 #include <stddef.h>
 
-void gpio_init()
+void gpio_init(void)
 {
 	for (size_t i = 0; i < 8; i++) {
 		GPIO_LPC_PORT(i)->dir = 0;

firmware/common/ice40_spi.c

@@ -54,17 +54,17 @@ void ice40_spi_write(ice40_spi_driver_t* const drv, uint8_t r, uint16_t v)
 	spi_bus_transfer(drv->bus, value, 3);
 }
 
-static void spi_ssp1_wait_for_tx_fifo_not_full()
+static void spi_ssp1_wait_for_tx_fifo_not_full(void)
 {
 	while ((SSP_SR(SSP1_BASE) & SSP_SR_TNF) == 0) {}
 }
 
-static void spi_ssp1_wait_for_rx_fifo_not_empty()
+static void spi_ssp1_wait_for_rx_fifo_not_empty(void)
 {
 	while ((SSP_SR(SSP1_BASE) & SSP_SR_RNE) == 0) {}
 }
 
-static void spi_ssp1_wait_for_not_busy()
+static void spi_ssp1_wait_for_not_busy(void)
 {
 	while (SSP_SR(SSP1_BASE) & SSP_SR_BSY) {}
 }

firmware/common/m0_sleep.c

@@ -20,7 +20,7 @@
  * Boston, MA 02110-1301, USA.
  */
 
-int main()
+int main(void)
 {
 	while (1) {}
 }

firmware/common/operacake_sctimer.c

@@ -55,7 +55,7 @@ static uint32_t default_output = 0;
  * On Praline, instead, MS0/CLK1 (SCT_CLK) is configured to output its
  * clock (f=2 * sample clock) to the SCTimer.
  */
-void operacake_sctimer_init()
+void operacake_sctimer_init(void)
 {
 	// We start by resetting the SCTimer
 	RESET_CTRL1 = RESET_CTRL1_SCT_RST;
@@ -216,7 +216,7 @@ void operacake_sctimer_set_dwell_times(struct operacake_dwell_times* times, int
 	SCT_CTRL &= ~SCT_CTRL_HALT_L(1);
 }
 
-void operacake_sctimer_stop()
+void operacake_sctimer_stop(void)
 {
 	// Halt timer
 	SCT_CTRL |= SCT_CTRL_HALT_L(1);
@@ -228,7 +228,7 @@ void operacake_sctimer_stop()
  * called by set_transceiver_mode so the HackRF starts capturing with the
  * same antenna selected each time.
  */
-void operacake_sctimer_reset_state()
+void operacake_sctimer_reset_state(void)
 {
 	SCT_CTRL |= SCT_CTRL_HALT_L(1);