firmware: standardize struct+typedef usage

Author: antoinevg

firmware/common/cpld_jtag.h

@@ -25,7 +25,7 @@
 
 #include "gpio.h"
 
-typedef struct jtag_gpio_t {
+typedef struct {
 	gpio_t gpio_tck;
 #ifndef PRALINE
 	gpio_t gpio_tms;

firmware/common/fault_handler.h

@@ -29,9 +29,7 @@
 // TODO: Move all this to a Cortex-M(?) include file, since these
 // structures are supposedly the same between processors (to an
 // undetermined extent).
-typedef struct armv7m_scb_t armv7m_scb_t;
-
-struct armv7m_scb_t {
+typedef struct {
 	volatile const uint32_t CPUID;
 	volatile uint32_t ICSR;
 	volatile uint32_t VTOR;
@@ -63,7 +61,7 @@ struct armv7m_scb_t {
 	volatile const uint32_t ID_ISAR4;
 	volatile const uint32_t __reserved_0x74_0x87[5];
 	volatile uint32_t CPACR;
-} __attribute__((packed));
+} __attribute__((packed)) armv7m_scb_t;
 
 static armv7m_scb_t* const SCB = (armv7m_scb_t*) SCB_BASE;
 

firmware/common/fpga.h

@@ -36,14 +36,11 @@ typedef enum {
 	FPGA_QUARTER_SHIFT_MODE_DOWN = 0b01,
 } fpga_quarter_shift_mode_t;
 
-struct fpga_driver_t; // IWYU pragma: keep - fixed in #1704
-typedef struct fpga_driver_t fpga_driver_t;
-
-struct fpga_driver_t {
+typedef struct {
 	ice40_spi_driver_t* bus;
 	uint8_t regs[FPGA_NUM_REGS];
 	uint8_t regs_dirty;
-};
+} fpga_driver_t;
 
 struct fpga_loader_t {
 	/* Start address added as an offset to all read() calls. */

firmware/common/gpio_lpc.h

@@ -29,7 +29,7 @@
  * register #defines and API declarations into separate header files.
  */
 
-typedef struct gpio_port {
+typedef struct {
 	volatile uint32_t dir; /* +0x000 */
 	uint32_t _reserved0[31];
 	volatile uint32_t mask; /* +0x080 */

firmware/common/i2c_lpc.h

@@ -28,7 +28,7 @@
 
 #include "i2c_bus.h"
 
-typedef struct i2c_lpc_config_t {
+typedef struct {
 	const uint16_t duty_cycle_count;
 } i2c_lpc_config_t;
 

firmware/common/ice40_spi.h

@@ -28,15 +28,12 @@
 #include "gpio.h"
 #include "spi_bus.h"
 
-struct ice40_spi_driver_t; // IWYU pragma: keep - fixed in #1704
-typedef struct ice40_spi_driver_t ice40_spi_driver_t;
-
-struct ice40_spi_driver_t {
+typedef struct {
 	spi_bus_t* const bus;
 	gpio_t gpio_select;
 	gpio_t gpio_creset;
 	gpio_t gpio_cdone;
-};
+} ice40_spi_driver_t;
 
 void ice40_spi_target_init(ice40_spi_driver_t* const drv);
 uint8_t ice40_spi_read(ice40_spi_driver_t* const drv, uint8_t r);

firmware/common/portapack.c

@@ -38,7 +38,7 @@ static void portapack_sleep_milliseconds(const uint32_t milliseconds)
 	delay(milliseconds * 40800);
 }
 
-typedef struct portapack_if_t {
+typedef struct {
 	gpio_t gpio_dir;
 	gpio_t gpio_lcd_rdx;
 	gpio_t gpio_lcd_wrx;

firmware/common/portapack.h

@@ -28,39 +28,39 @@
 
 #define ARRAY_SIZEOF(x) (sizeof(x) / sizeof(x[0]))
 
-typedef struct ui_color_t {
+typedef struct {
 	uint16_t v;
 } ui_color_t;
 
-typedef struct ui_point_t {
+typedef struct {
 	int16_t x;
 	int16_t y;
 } ui_point_t;
 
-typedef struct ui_size_t {
+typedef struct {
 	int16_t width;
 	int16_t height;
 } ui_size_t;
 
-typedef struct ui_rect_t {
+typedef struct {
 	ui_point_t point;
 	ui_size_t size;
 } ui_rect_t;
 
-typedef struct ui_bitmap_t {
+typedef struct {
 	ui_size_t size;
 	const uint8_t* const data;
 } ui_bitmap_t;
 
-typedef struct ui_font_t {
+typedef struct {
 	const ui_size_t glyph_size;
 	const uint8_t* const data;
 	char c_start;
 	size_t c_count;
 	size_t data_stride;
 } ui_font_t;
 
-typedef struct portapack_t {
+typedef struct {
 } portapack_t;
 
 void portapack_init(void);

firmware/common/radio.h

@@ -215,7 +215,7 @@ typedef enum {
  */
 typedef fp_40_24_t (*sample_rate_fn)(const fp_40_24_t sample_rate, const bool program);
 
-typedef struct radio_t {
+typedef struct {
 	radio_config_mode_t config_mode;
 	uint64_t config[RADIO_NUM_BANKS][RADIO_NUM_REGS];
 	volatile uint32_t regs_dirty;

firmware/common/rf_path.h

@@ -45,7 +45,7 @@ typedef enum {
 	RF_PATH_FILTER_HIGH_PASS = 2,
 } rf_path_filter_t;
 
-typedef struct rf_path_t {
+typedef struct {
 	uint8_t switchctrl;
 #ifdef HACKRF_ONE
 	gpio_t gpio_hp;