Refactor hackrf_core.x in preparation for removal. (1/3)#1705
Merged
mossmann merged 7 commits intogreatscottgadgets:mainfrom Apr 23, 2026
Merged
Refactor hackrf_core.x in preparation for removal. (1/3)#1705mossmann merged 7 commits intogreatscottgadgets:mainfrom
hackrf_core.x in preparation for removal. (1/3)#1705mossmann merged 7 commits intogreatscottgadgets:mainfrom
Conversation
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
4 times, most recently
from
3351fdc to
972eb9b
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
12 times, most recently
from
74f5366 to
0d4817f
Compare
antoinevg
changed the title
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
3 times, most recently
from
356d1f8 to
0f8fa86
Compare
antoinevg
changed the title
hackrf_core.x in preparation for removal.
This was referenced Apr 2, 2026
Closed
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
4 times, most recently
from
021cd70 to
86c493f
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
from
86c493f to
5d513df
Compare
antoinevg
changed the title
hackrf_core.x in preparation for removal.hackrf_core.x in preparation for removal. (1/3)
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
from
5d513df to
7e469ff
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
3 times, most recently
from
cc4964f to
1ef7688
Compare
mossmann
requested changes
Apr 23, 2026
Member
mossmann
left a comment
mossmann
left a comment
There was a problem hiding this comment.
Overall this looks good, and the final commit builds fine, but I would like to see some rearrangement.
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
from
1ef7688 to
c835a28
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
from
c835a28 to
de8d0eb
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core
branch
from
de8d0eb to
5672be9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves a number of items out of
hackrf_corein preparation for removing it entirely:cpu_clock.xclock_gen.xpower.xleds.xclkin_ctrl_set=>clkin.xnarrowband_filter_set=>fpga.xtrigger_enable=>clock_gen.xFollow-up PR's address the remaining items:
hackrf_core.xdriver instances todrivers.x(2/3) #1709hackrf_core.xtopins.x(3/3) #1710