Conversation
mossmann
force-pushed
the
portapack-sweep
branch
3 times, most recently
from
9261aa6 to
0b02d13
Compare
Merged
The PortaPack UI hides leading zeros in the most significant digits. Previously zeros in the 1 MHz column and above were hidden. Now zeros in the 10 MHz column and above are hidden.
mossmann
force-pushed
the
portapack-sweep
branch
from
0b02d13 to
0205dd4
Compare
martinling
approved these changes
Apr 10, 2026
Member
There was a problem hiding this comment.
I was previously able to reproduce a hang in sweep mode with hackrf_sweep -f 2100:2220 on HackRF One & PortaPack, with an earlier version of #1708, at commit af77d98.
I wasn't able to reproduce the hang with any of:
As such, to test the fix in this PR, I first rebased the branch on commit af77d98. My rebased version can be seen here.
I've confirmed that:
- the rebased version fixes the hang
- sweep mode also works correctly with the non-rebased version
- both versions have the expected change to display behaviour below 1MHz
And the code changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug that can cause shortfalls in sweep mode with PortaPack due to UI updates taking too long.
Also show 0 in MHz column on PortaPack display which makes it clearer when tuned below 1 MHz.